Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DV2: publish cdk + redshift #33335

Merged
merged 6 commits into from
Dec 12, 2023
Merged

DV2: publish cdk + redshift #33335

merged 6 commits into from
Dec 12, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Dec 12, 2023

forgot that JDBCSqlGenerator is actually in the cdk. PR to publish cdk with #33307 and then publish redshift.

@edgao edgao requested a review from a team as a code owner December 12, 2023 01:56
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:02pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/redshift labels Dec 12, 2023
Copy link
Contributor

github-actions bot commented Dec 12, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@gisripa gisripa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to ping you tomorrow for this 😄

@edgao
Copy link
Contributor Author

edgao commented Dec 12, 2023

lol. I'm probably going to sleep soon, but if you want to get the cdk+connector published tonight, that might save us a day of iteration b/c timezones

(otherwise I'll just kick off the publish tomorrow morning)

@edgao
Copy link
Contributor Author

edgao commented Dec 12, 2023

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7184146711
✅ Successfully published Java CDK version=0.7.2!

@edgao edgao merged commit 2ffaef1 into master Dec 12, 2023
21 checks passed
@edgao edgao deleted the edgao/redshift/publish branch December 12, 2023 20:31
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
tmathew0309 pushed a commit to tmathew0309/airbyte that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit checklist-action-run connectors/destination/redshift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants