🎉 Source Salesforce new ContentDocumentLink stream

[midavadim]

What

#30819
new ContentDocumentLink stream

How

ContentDocumentLink is implemented as HttpSubStream, where parent stream is ContentDocument.
Implemented Rest and Bulk classes.
ContentDocumentLink does not support incremental syncs due to API restrictions for this particular stream:
https://developer.salesforce.com/docs/atlas.en-us.object_reference.meta/object_reference/sforce_api_objects_contentdocumentlink.htm

• You can't run a query without filters against ContentDocumentLink.
• You can't filter on ContentDocument fields if you're filtering by ContentDocumentId. You can only filter on ContentDocument fields if you're filtering by LinkedEntityId.
• A SOQL query must filter on one of Id, ContentDocumentId, or LinkedEntityId

Possible solution:

1. SELECT ... FROM ContentDocumentLink WHERE ContentDocumentId = '<ContentDocument.Id>'

• but it means we need each separate request for each ContentDocument node.

2. SELECT ... FROM ContentDocumentLink WHERE ContentDocumentId in (SELECT Id from ContentDocument)

• does not support by API

3. SELECT ... FROM ContentDocumentLink WHERE ContentDocumentId IN ( < LIST OF IDS > )

• THIS APPROACH WAS IMPLEMENTED

🚨 User Impact 🚨

No impact

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 15, 2023 9:44am

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[artem1205]

please add unit test for your changes, specifically for BULK API query

[midavadim]

please add unit test for your changes, specifically for BULK API query

added

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ TypeError: 'NoneType' object is not subscriptable /airbyte/integration_code/source_salesforce/str... View Issue

_{Did you find this useful? React with a 👍 or 👎}