New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Source Jira: Fix check command #33353
Conversation
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 馃帀 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
else: | ||
logger.info(f"API Token have access to stream: {stream.name}, so check is successful.") | ||
return True, None | ||
return False, "This API Token does not have permission to read any of the resources." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need to try read all streams on check? this is certified connector and check command should run fast. we can check only known permissions/scopes, and availability strategy will work while reading and skip stream if it is not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darynaishchenko The updated check method now passes if at least one stream is readable. Without this inspection, the check will be successful even without access to any resources.
242e474
to
0bc46de
Compare
What
This PR updates the check command to verify access to any available resources instead of limiting the check to just the Labels endpoint.
How
Implemented an AvailabilityStrategy in the base class to enable skipping streams without required permissions. Removed
should_retry
methods to avoid duplicating the logic ofskip_http_status_codes
, which already handles skipping slices in case of errors. This enhancement ensures that the sync will not fail if the API token lacks permission for certain resources.