New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3, Google Drive, Azure Blob Storage: Update cdk #33411
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@clnoll @aaronsteers pinging you on this - as we can't roll out the remote processing feature right now without weird behavior, I hid it temporarily by adjusting the spec in the connector. Once the linked issue is resolved, it can be shown "properly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me @flash1293, just one small question.
@@ -67,22 +67,19 @@ class Config: | |||
def documentation_url(cls) -> str: | |||
return "https://docs.airbyte.com/integrations/sources/google-drive" | |||
|
|||
@staticmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this have to be reverted when the platform issue is fixed? Couldn't quite see why google drive had this method but the other sources don't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been moved into the abstract file based spec and doesn't have to be moved back. It's only on google drive because the other connectors didn't have oneOfs in their spec which made it necessary (Google drive has two auth modes)
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
This PR rolls out #33300 and #32781 to all relevant source connectors.
As remote processing is currently experiencing the issue described in https://github.com/airbytehq/airbyte-internal-issues/issues/6199, this option is temporarily hidden from the spec. Once the platform supports managing secrets in arrays correctly, this limitation will be lifted.