New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Google Sheets, Google Drive, Apify dataset and connector templates for airbyte-lib #33414
Prepare Google Sheets, Google Drive, Apify dataset and connector templates for airbyte-lib #33414
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
from airbyte_cdk.entrypoint import launch | ||
from .source import Source{{properCase name}} | ||
|
||
if __name__ == "__main__": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the template file different from the connector's implementation?
I'd expect this file to only contain the run method and for the if __name__ == "__main__"
to be in the main.py file
Good catch @girarda ! This is exactly how it should look like, fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the long run, I'd like to further reduce the amount of code needed, but this is already very well tuned. Also in the long run, it would be good to make airbyte-ci
depend on the CLI entrypoint or the new run:run
pattern, instead of ../main.py
which is outside the module folder.
…lates for airbyte-lib (#33414)
…lates for airbyte-lib (airbytehq#33414)
…lates for airbyte-lib (airbytehq#33414)
…lates for airbyte-lib (airbytehq#33414)
This PR prepares some exemplary python connectors for airbyte-lib consumption.
The main changes are:
run.py
file within the package that will be publishedmain.py
fileTo make new connectors compatible with airbyte-lib from the start, the connector templates are updated as well.