Repository navigation
mssql-source: remove LEGACY state flag - #33481
Merged
Subodh Chaturvedi (subodh1810) merged 23 commits intoDec 19, 2023
Merged
Subodh Chaturvedi (subodh1810) merged 23 commits into
Subodh Chaturvedi (subodh1810) merged 23 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Subodh Chaturvedi (subodh1810)
changed the base branch from
master
to
cdk-changes-remove-legacy-state
December 14, 2023 06:14
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…e-legacy-state-mssql-source
Octavia Squidington III (octavia-squidington-iii)
removed
the
CDK
Octavia Squidington IV (octavia-squidington-iv)
requested a review
from a team
December 14, 2023 10:06
| protected boolean supportsPerStream() { | ||
| return true; | ||
| } | ||
| protected void dropSchemas() {} |
Contributor
There was a problem hiding this comment.
remove
# Conflicts: # airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties # airbyte-cdk/java/airbyte-cdk/db-sources/src/test/java/io/airbyte/cdk/integrations/source/relationaldb/AbstractDbSourceTest.java
…e-legacy-state-mssql-source
Subodh Chaturvedi (subodh1810)
requested a review
from Stephane Geneix (stephane-airbyte)
December 15, 2023 12:11
| testdb.getJdbcUrl(), | ||
| Map.of("encrypt", "false")); | ||
| Map.of("encrypt", "false"), | ||
| CONNECTION_TIME); |
Contributor
There was a problem hiding this comment.
you can also pass JdbcConnector.CONNECT_DEFAULT_TIMEOUT. But this is just fine too
Octavia Squidington IV (octavia-squidington-iv)
requested review from
a team
December 15, 2023 15:07
| container.getJdbcUrl(), | ||
| connectionProperties); | ||
| connectionProperties, | ||
| CONNECTION_TIMEOUT); |
Contributor
There was a problem hiding this comment.
I'm surprised the test passes with this change. I expect you'd need to pass new MsSqlSource.getConnectionTimeout(connectionProperties)
Stephane Geneix (stephane-airbyte)
approved these changes
Dec 15, 2023
Stephane Geneix (stephane-airbyte)
left a comment
Stephane Geneix (stephane-airbyte)
left a comment
Contributor
There was a problem hiding this comment.
I'm surprised the tests are passing. If they're causing you issues, I commented on what's the right value to pass
# Conflicts: # airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Subodh Chaturvedi (subodh1810)
deleted the
cdk-changes-remove-legacy-state-mssql-source
branch
December 19, 2023 18:16
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : #33290
Based on PR #33434