mssql-source: remove LEGACY state flag #33481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
subodh1810
changed the base branch from
master
to
cdk-changes-remove-legacy-state
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…e-legacy-state-mssql-source
| protected boolean supportsPerStream() { | ||
| return true; | ||
| } | ||
| protected void dropSchemas() {} |
# Conflicts: # airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties # airbyte-cdk/java/airbyte-cdk/db-sources/src/test/java/io/airbyte/cdk/integrations/source/relationaldb/AbstractDbSourceTest.java
…e-legacy-state-mssql-source
| @@ -147,7 +144,8 @@ protected void setup() { | |||
| testdb.getPassword(), | |||
| testdb.getDatabaseDriver().getDriverClassName(), | |||
| testdb.getJdbcUrl(), | |||
| Map.of("encrypt", "false")); | |||
| Map.of("encrypt", "false"), | |||
| CONNECTION_TIME); | |||
There was a problem hiding this comment.
you can also pass JdbcConnector.CONNECT_DEFAULT_TIMEOUT. But this is just fine too
| @@ -25,7 +28,8 @@ protected void testCreatingDataSourceWithConnectionTimeoutSetBelowDefault() { | |||
| container.getPassword(), | |||
| container.getDriverClassName(), | |||
| container.getJdbcUrl(), | |||
| connectionProperties); | |||
| connectionProperties, | |||
| CONNECTION_TIMEOUT); | |||
There was a problem hiding this comment.
I'm surprised the test passes with this change. I expect you'd need to pass new MsSqlSource.getConnectionTimeout(connectionProperties)
stephane-airbyte
approved these changes
Dec 15, 2023
# Conflicts: # airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
octavia-squidington-iii
added
the
area/documentation
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #33290
Based on PR #33434