-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jdbc-sources: migrate to PER-STREAM state #33485
jdbc-sources: migrate to PER-STREAM state #33485
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the CDK changes before doing a full review of this.
One thing to change is in the individual build.gradle files, you'll have to change the cdkVersionRequired rather than the useLocalCdk. Once the CDK is published, you'll be able to update this review accordingly (yes, the CDK changing process is really annoying)
…e-legacy-state-uncertified-jdbc-sources
…e-legacy-state-uncertified-jdbc-sources
Issue : #33290
Based on PR #33434