Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdbc-sources: migrate to PER-STREAM state #33485

Merged

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented Dec 14, 2023

Issue : #33290
Based on PR #33434

@subodh1810 subodh1810 self-assigned this Dec 14, 2023
@subodh1810 subodh1810 requested a review from a team as a code owner December 14, 2023 06:55
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 8:28am

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 14, 2023 11:47
Copy link
Contributor

@stephane-airbyte stephane-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the CDK changes before doing a full review of this.
One thing to change is in the individual build.gradle files, you'll have to change the cdkVersionRequired rather than the useLocalCdk. Once the CDK is published, you'll be able to update this review accordingly (yes, the CDK changing process is really annoying)

Base automatically changed from cdk-changes-remove-legacy-state to master December 18, 2023 17:31
@subodh1810 subodh1810 requested a review from a team as a code owner December 18, 2023 17:31
@subodh1810 subodh1810 merged commit 0c3d12b into master Dec 19, 2023
32 of 33 checks passed
@subodh1810 subodh1810 deleted the cdk-changes-remove-legacy-state-uncertified-jdbc-sources branch December 19, 2023 10:08
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants