New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Google Ads: added handling for 401 error while parsing response. added metrics.cost_micros to ad_groups stream #33494
Merged
darynaishchenko
merged 20 commits into
master
from
daryna/source-google-ads/oc-auth-error
Jan 9, 2024
Merged
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d19987e
added handling for 401 error while parsing response
darynaishchenko 59f276a
updated changelog
darynaishchenko 8c2d8eb
Merge branch 'master' into daryna/source-google-ads/oc-auth-error
darynaishchenko c0c5c30
updated expected records
darynaishchenko 38d6bf6
added metrics.cost_micros field to ad_group stream
darynaishchenko 6484760
Merge branch 'master' into daryna/source-google-ads/oc-auth-error
darynaishchenko fd1af0c
updated expected records
darynaishchenko b1a493a
updated expected records
darynaishchenko 9b52fc6
Merge branch 'master' into daryna/source-google-ads/oc-auth-error
darynaishchenko a2f3392
Merge branch 'master' into daryna/source-google-ads/oc-auth-error
darynaishchenko 09a701f
updated expected records
darynaishchenko 0edc4eb
added traced_exception func, updated connector version
darynaishchenko c01f6d1
Merge branch 'master' into daryna/source-google-ads/oc-auth-error
darynaishchenko f57d67f
format fix
darynaishchenko 1ebb3b4
added ignored fields
darynaishchenko 05ed28a
added 401 handling to request_records_job func
darynaishchenko d227cd1
Merge branch 'master' into daryna/source-google-ads/oc-auth-error
darynaishchenko d481a88
added 401 handling to read records
darynaishchenko f1bc200
Merge branch 'master' into daryna/source-google-ads/oc-auth-error
darynaishchenko 531718d
format fix
darynaishchenko File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
6 changes: 2 additions & 4 deletions
6
airbyte-integrations/connectors/source-google-ads/integration_tests/expected_records.jsonl
Large diffs are not rendered by default.
Oops, something went wrong.
7 changes: 2 additions & 5 deletions
7
...-integrations/connectors/source-google-ads/integration_tests/expected_records_click.jsonl
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to incorporate this error handling into the
traced_exception
function located inutils.py
? This would centralize error handling, making it more manageable and consistent across the connector.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated with traced_exception