Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: consider nested .gitignore files in format #33497

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Dec 14, 2023

What

A missing wildcard in the .gitignore path match made format not consider git ignore rules of nested .gitignore files.

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 3:24pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere force-pushed the augustin/12-14-airbyte-ci_consider_nested_.gitignore_files_in_format branch from c8f690d to 32e49be Compare December 14, 2023 15:24
@alafanechere alafanechere marked this pull request as ready for review December 14, 2023 15:24
@alafanechere alafanechere requested review from a team and postamar and removed request for a team December 14, 2023 15:24
@alafanechere alafanechere enabled auto-merge (squash) December 14, 2023 15:25
@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="minor fix on airbyte-ci format"

@octavia-approvington
Copy link
Contributor

Lets do it!
giddddy-up

@alafanechere alafanechere merged commit 479502c into master Dec 14, 2023
22 of 23 checks passed
@alafanechere alafanechere deleted the augustin/12-14-airbyte-ci_consider_nested_.gitignore_files_in_format branch December 14, 2023 16:07
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants