Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Salesforce: concurrent incremental syncs #33522

Merged
merged 1 commit into from Feb 5, 2024

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Dec 15, 2023

What

Updates the Salesforce connector to use the Concurrent CDK for incremental syncs, in addition to full refresh.

How

Updates the connector to use the new state converter added to the CDK in #33531.

@clnoll clnoll requested a review from a team as a code owner December 15, 2023 03:24
@clnoll clnoll marked this pull request as draft December 15, 2023 03:24
Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 1:04am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit labels Dec 15, 2023
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@clnoll clnoll force-pushed the source-salesforce-concurrent-incremental branch from b31e8f1 to ed7bfa8 Compare December 15, 2023 03:25
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 15, 2023 03:25
@clnoll clnoll force-pushed the source-salesforce-concurrent-incremental branch from ed7bfa8 to 1c6edcc Compare December 15, 2023 03:47
@clnoll clnoll force-pushed the source-salesforce-concurrent-incremental branch from 1c6edcc to 59e0596 Compare December 15, 2023 14:34
@clnoll clnoll changed the base branch from master to concurrent-cdk-isomillisstateconverter December 15, 2023 14:34
@clnoll clnoll force-pushed the source-salesforce-concurrent-incremental branch from 59e0596 to 5f5700a Compare December 15, 2023 14:38
@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation and removed CDK Connector Development Kit labels Dec 15, 2023
@clnoll clnoll force-pushed the concurrent-cdk-isomillisstateconverter branch 5 times, most recently from 6a8e1a7 to 07519e5 Compare December 15, 2023 22:08
@clnoll clnoll force-pushed the source-salesforce-concurrent-incremental branch from 5f5700a to 548bba6 Compare December 15, 2023 23:57
@clnoll clnoll force-pushed the concurrent-cdk-isomillisstateconverter branch 3 times, most recently from d785f0f to 8c76865 Compare December 18, 2023 16:18
@clnoll clnoll force-pushed the source-salesforce-concurrent-incremental branch from 548bba6 to 5b9cb34 Compare December 19, 2023 16:08
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! :shipit:

Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@clnoll clnoll force-pushed the source-salesforce-concurrent-incremental branch from b593b0e to 87b7566 Compare January 30, 2024 01:03
@clnoll clnoll merged commit 5571fd0 into master Feb 5, 2024
29 of 30 checks passed
@clnoll clnoll deleted the source-salesforce-concurrent-incremental branch February 5, 2024 14:56
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants