Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Hubspot: fix query string length for properties with history #33527

Merged
merged 4 commits into from
Dec 15, 2023
Merged

🐛 Source Hubspot: fix query string length for properties with history #33527

merged 4 commits into from
Dec 15, 2023

Conversation

roman-yermilov-gl
Copy link
Contributor

What

Fixing an error: 414 Client Error: URI Too Long for url: https://api.hubapi.com/deals/v1/deal/paged?propertiesWithHistory=..

How

Make query string calculated correctly by defining correct term representation for IURLPropertyRepresentation

@roman-yermilov-gl roman-yermilov-gl self-assigned this Dec 15, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 6:58pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited by roman-yermilov-gl
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 15, 2023
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review December 15, 2023 13:26
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 15, 2023 13:27
@roman-yermilov-gl roman-yermilov-gl linked an issue Dec 15, 2023 that may be closed by this pull request
Source Hubspot: airbyte_cdk.utils.traced_exception.AirbyteTracedException: 414 Client Error: URI Too Long for url: https://api.hubapi.com/deals/v1/deal/paged?propertiesWithHistory= #33528
Closed
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 15, 2023 18:45
lazebnyi
lazebnyi approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roman-yermilov-gl roman-yermilov-gl enabled auto-merge (squash) December 15, 2023 19:03
@roman-yermilov-gl roman-yermilov-gl merged commit 99ec45f into master Dec 15, 2023
27 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-hubspot-property-history-url-fix branch December 15, 2023 19:45
timroes pushed a commit that referenced this pull request Dec 19, 2023
@roman-yermilov-gl @timroes
🐛 Source Hubspot: fix query string length for properties with history (…
d9643c9 
…#33527)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
🐛 Source Hubspot: fix query string length for properties with history (…
2b65e5c 
…airbytehq#33527)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
🐛 Source Hubspot: fix query string length for properties with history (…
c518f9e 
…airbytehq#33527)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
🐛 Source Hubspot: fix query string length for properties with history (…
d3d03bd 
…airbytehq#33527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem1205 artem1205 artem1205 approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@roman-yermilov-gl roman-yermilov-gl

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Milestone
No milestone
4 participants
@roman-yermilov-gl @artem1205 @lazebnyi @octavia-squidington-iii