Change the run-ab-platform.sh script to support other shells than bash #33554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution @nhuray I asked the team to make a review to the change as my shell script skill are good enough 📟 |
|
Tested this locally and it works fine on my end! LGTM 👍 |
cpdeethree
approved these changes
Dec 19, 2023
timroes
pushed a commit
that referenced
this pull request
Dec 19, 2023
|
@cpdeethree Thanks for merging that small PR. |
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is small PR to remove the use of the bash specific variable
BASH_SOURCEin therun-ab-platform.shscript in order to make it run on other shells than bash (tested on fish)How
After reading that explanation on Stackoverflow, I just changed the variable
${BASH_SOURCE}to use${0}Changing it allows to run the script on
fishshell.Before:
After: