Fix cdk unit test #33572
Merged
Fix cdk unit test #33572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Closed
maxi297
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
I'm good with this change. However, it makes me very worried about how we use the pendulum library. str(<pendulum.Datetime>) is kind of scary as __str__ is defined as an informal and nicely printable string https://docs.python.org/3/reference/datamodel.html#object.__str__
|
I agree @maxi297 , I first wanted to fix it that route by explicitly serializing to an iso string, but it spiraled into a pretty big change and I wanted to unblock PRs quickly: #33571 I opened an issue to solve this in a better way: https://github.com/airbytehq/airbyte-internal-issues/issues/2356 |
timroes
pushed a commit
that referenced
this pull request
Dec 19, 2023
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pendulum got updated to 3.0: https://pypi.org/project/pendulum/#history
As we don't pin the version, this caused some errors. This is setting it to lower than 3.0, but we should upgrade in time