airbyte-lib: Add path executor #33600
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aaronsteers
force-pushed
the
flash1293/airbyte-lib
branch
from
22f9504
to
aae69e5
Compare
|
@flash1293 I think you ran into a bad merge. You'll have to close this PR, rebase your branch on master and recreate a PR (if you just rebase your branch, everyone currently on this PR will be ping everytime something happens here) |
|
@flash1293 - When I tried to use Graphite on my own PRs (based on the same base as this one), it force pushed all 3 branches, and may have been the cause of this one getting into a bad state. I updated the base from master and this one from the base branch, and it looks okay now. |
| def get_connector(name: str, version: str = "latest", config: Optional[Dict[str, Any]] = None, use_venv: bool = True): | ||
| """ | ||
| Get a connector by name and version. | ||
| :param name: connector name | ||
| :param version: connector version - if not provided, the most recent version will be used | ||
| :param config: connector config - if not provided, you need to set it later via the set_config method | ||
| :param use_venv: whether to use a virtual environment to run the connector. If False, the connector is expected to be available on the path (e.g. installed via pip). If True, the connector will be installed in a virtual environment. | ||
| """ |
There was a problem hiding this comment.
I read "use_venv" the first time to mean that "false" would still be managed, but would be installed by AirbyteLib without venv isolation. Wdyt of a name like "already_installed" or "needs_install" or similar to distinguish AirbyteLib-managed installations vs user-managed?
There was a problem hiding this comment.
what about "auto_install"?
There was a problem hiding this comment.
I merged already, I will implement this on the base PR
This PR adds a path executor which allows to bypass the venv if the connector is installed locally and available via a cli script.
This behavior can be enabled via setting the
use_venvparam ofget_connectorto false: