Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Destination redshift: reenable T+D optimizations; bigquery+snowflake: bump to latest CDK version #33704

Merged
merged 7 commits into from Dec 21, 2023
Merged

🎉 Destination redshift: reenable T+D optimizations; bigquery+snowflake: bump to latest CDK version #33704

merged 7 commits into from Dec 21, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Dec 20, 2023 •
edited

closes #33685

  1. revert the test change in https://github.com/airbytehq/airbyte/pull/33124/files#diff-f687bfd57a60258955e78d454447802be81912d73fec4a28916f909c3dca15d4
  2. Implement the method correctly in JdbcDestinationHandler (this code is mostly copied from the preexisting RedshiftDestinationHandler.getMinTimestamp method)
  3. Remove redundant code from RedshiftDestinationHandler

snowflake+bigquery technically aren't affected by this (the only CDK code change is in the JdbcDestinationHandler, which neither of them rely on) but figured I might as well trigger their test suites.

@edgao edgao requested a review from a team as a code owner December 20, 2023 23:41
@vercel Vercel
Copy link

vercel bot commented Dec 20, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 1:15am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit labels Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited by edgao

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

edgao
edgao commented Dec 20, 2023
View reviewed changes
...ava/io/airbyte/cdk/integrations/destination/jdbc/typing_deduping/JdbcDestinationHandler.java
// Decrement by 1 second since timestamp precision varies between databases.
final Optional<Instant> ts = minUnloadedTimestamp
.map(Timestamp::toInstant)
.map(i -> i.minus(1, ChronoUnit.SECONDS));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is slightly different from the original redshift implementation - instead of doing a timestamp subtraction within redshift, we just query the raw timestamp and decrement it in java code. Timestamp math can be dialect-specific, so probably not a good idea to have it in a base Jdbc implementation.

@edgao edgao changed the title Destination redshift: reenable T+D optimizations; bigquery+snowflake: bump to latest CDK version 🎉 Destination redshift: reenable T+D optimizations; bigquery+snowflake: bump to latest CDK version Dec 21, 2023
@edgao
Copy link
Contributor Author

edgao commented Dec 21, 2023 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7282713166
✅ Successfully published Java CDK version=0.10.0!

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023 •
edited

Warning

🚨 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master.

@edgao
Copy link
Contributor Author

edgao commented Dec 21, 2023

/approve-and-merge reason="shipping one last redshift beta update; all tests passing"

@octavia-approvington
Copy link
Contributor

Approve this
imagine the commander saying yes

@octavia-approvington octavia-approvington merged commit 1d76fd2 into master Dec 21, 2023
24 of 28 checks passed
@octavia-approvington octavia-approvington deleted the edgao/redshift/cdk_upgrade branch December 21, 2023 03:09
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@edgao @jatinyadav-cc
🎉 Destination redshift: reenable T+D optimizations; bigquery+snowflak…
054a30c 
…e: bump to latest CDK version (airbytehq#33704)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@edgao @jatinyadav-cc
🎉 Destination redshift: reenable T+D optimizations; bigquery+snowflak…
5ede9f6 
…e: bump to latest CDK version (airbytehq#33704)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@edgao @jatinyadav-cc
🎉 Destination redshift: reenable T+D optimizations; bigquery+snowflak…
d89cd8a 
…e: bump to latest CDK version (airbytehq#33704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler left review comments

@jbfbell jbfbell jbfbell approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit checklist-action-run connectors/destination/bigquery connectors/destination/redshift connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JDBC Destinations] Fix Failing Unit tests
5 participants
@edgao @octavia-approvington @evantahler @jbfbell @octavia-squidington-iii