Source Iterable: update to use latest version of CDK #3378

htrueman · 2021-05-12T17:09:00Z

What

Requirements updated to CDK.
airbyte-protocol and base-python requirements removed.
Closes #3044

Pre-merge Checklist

Run integration tests
Publish Docker images

Recommended reading order

setup.py
the rest

sherifnada

LGTM! please make sure to run /test and /publish (with bumping the version) before merging

airbyte-integrations/connectors/source-iterable/setup.py

airbyte-integrations/connectors/source-slack-singer/sample_files/configured_catalog.json

keu · 2021-05-12T18:34:52Z

@htrueman
It is not clear from PR's title what these change for, i.e. no name of connector and changes have two different connectors (slack and iterable)

keu

see my comments

airbyte-protocol and base-python requirements removed.

airbyte-integrations/connectors/source-iterable/main_dev.py

* Format. * Bump versions.

README.md updated

htrueman · 2021-05-13T10:31:46Z

/test connector=source-iterable

🕑 source-iterable https://github.com/airbytehq/airbyte/actions/runs/838593494
❌ source-iterable https://github.com/airbytehq/airbyte/actions/runs/838593494

* Add Acceptance Tests to Stripe Connector * move configured_catalog.json to sample_files * bump version Co-authored-by: ykurochkin <y.kurochkin@zazmic.com>

htrueman · 2021-05-13T16:28:40Z

/test connector=source-iterable

🕑 source-iterable https://github.com/airbytehq/airbyte/actions/runs/839504209
❌ source-iterable https://github.com/airbytehq/airbyte/actions/runs/839504209

airbyte-integrations/connectors/source-iterable/Dockerfile

keu · 2021-05-13T20:13:53Z

/test connector=source-iterable

🕑 source-iterable https://github.com/airbytehq/airbyte/actions/runs/839504209
❌ source-iterable https://github.com/airbytehq/airbyte/actions/runs/839504209

you need to check .dockerignore for files that included in container

* FB Marketing source #1390 - returning buffered record while incremental sync * FB Marketing source #1390 - improving checking while syncing buffered record * FB Marketing source #1390 - adding loop_back to IncrementalStreamAPI * FB Marketing source #1390 - bump version * FB Marketing source #1390 - add CHANGELOG.md

sherifnada

@htrueman sorry missed this in my first review: read_stream doesn't exist anymore. This was written on an old version of the CDK. Could you change it to use read_records and take the appropriate parameters?

* add configuration for bumping webapp versionn * set to current version * Bump version: 0.16.0-alpha → 0.16.1-alpha * Revert "Bump version: 0.16.0-alpha → 0.16.1-alpha" Thiss reverts commit fdbf6dc. * also update package lock so we don't run into files changed errors * use 0.19.0-alpha * add npm webapp version

* Add CDK Speedrun document. * Finish speedrun doc. * Address review comments * Add to SUMMARY.md Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>

* Add Rust as a connector specific dependency to source-file * Add more details about installation. * Markdown lines are weird. Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>

htrueman · 2021-05-16T18:21:01Z

/test connector=source-iterable

🕑 source-iterable https://github.com/airbytehq/airbyte/actions/runs/847499571
✅ source-iterable https://github.com/airbytehq/airbyte/actions/runs/847499571

@avaidyanatha

* add deploy on windows steps * correct minor * change suggestions by @avaidyanatha

* Display icons * Improve icons views

…rable-update-to-cdk

htrueman · 2021-05-17T13:38:28Z

/test connector=source-iterable

🕑 source-iterable https://github.com/airbytehq/airbyte/actions/runs/849938587
✅ source-iterable https://github.com/airbytehq/airbyte/actions/runs/849938587

Fixes issue #613. Normalization is not yet enabled. This will have to be added at a later point.

* Keep normalization backward compatible with old settings from destination * Bumpversion normalization image

)

…artifacts (#3416) * Archive test reports in github workflow * Archive Test reports only when failures

Fixing some issues with `SqlServerOperations`, which was out of sync with recent changes to `SqlOperations`.

* add redirect to cdk tutorial page * change path to cdk README.md

keu

lgtm

…rable-update-to-cdk

htrueman · 2021-05-18T14:56:01Z

/test connector=source-iterable

🕑 source-iterable https://github.com/airbytehq/airbyte/actions/runs/853741745
✅ source-iterable https://github.com/airbytehq/airbyte/actions/runs/853741745

htrueman · 2021-05-18T15:10:46Z

/publish connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/853784847
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/853784847

Issue fixed. Merging the branch.

auto-assign bot requested review from masonwheeler and sherifnada May 12, 2021 17:09

htrueman requested review from yevhenii-ldv, grebessi, keu, po3na4skld, vitaliizazmic, vovavovavovavova and Zirochkaa May 12, 2021 17:24

sherifnada approved these changes May 12, 2021

View reviewed changes

airbyte-integrations/connectors/source-iterable/setup.py Outdated Show resolved Hide resolved

keu reviewed May 12, 2021

View reviewed changes

airbyte-integrations/connectors/source-slack-singer/sample_files/configured_catalog.json Outdated Show resolved Hide resolved

keu requested changes May 12, 2021

View reviewed changes

htrueman changed the title ~~Requirements updated to CDK.~~ Source Iterable: update to use latest version of CDK May 13, 2021

Requirements updated to CDK.

b3893c4

airbyte-protocol and base-python requirements removed.

htrueman force-pushed the htrueman/source-iterable-update-to-cdk branch from ae0dda1 to b3893c4 Compare May 13, 2021 08:13

keu requested changes May 13, 2021

View reviewed changes

airbyte-integrations/connectors/source-iterable/main_dev.py Show resolved Hide resolved

Bugfix: BufferedStreamConsumer. (#3387)

99c7ac2

* Format. * Bump versions.

po3na4skld approved these changes May 13, 2021

View reviewed changes

main_dev.py renamed to main.py

8e4e252

README.md updated

keu approved these changes May 13, 2021

View reviewed changes

yevhenii-ldv and others added 2 commits May 13, 2021 18:40

Source Stripe: Add Acceptance Tests to Stripe Connector (#3367)

d44fc16

* Add Acceptance Tests to Stripe Connector * move configured_catalog.json to sample_files * bump version Co-authored-by: ykurochkin <y.kurochkin@zazmic.com>

Legacy lib references removed

70ad984

keu requested changes May 13, 2021

View reviewed changes

airbyte-integrations/connectors/source-iterable/Dockerfile Outdated Show resolved Hide resolved

sherifnada previously requested changes May 13, 2021

View reviewed changes

Stop formatting python with spotless (#3388)

0df5317

jrhizor and others added 4 commits May 14, 2021 14:45

Add a CDK speedrun tutorial doc (#3403)

576d932

* Add CDK Speedrun document. * Finish speedrun doc. * Address review comments * Add to SUMMARY.md Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>

Add Rust as a connector specific dependency to source-file (#3426)

6ffada8

* Add Rust as a connector specific dependency to source-file * Add more details about installation. * Markdown lines are weird. Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>

API update to latest airbyte-cdk version

47878c6

marcosmarxm and others added 4 commits May 16, 2021 19:44

Add section Deploy Local on Windows (#3425)

18c1d6e

* add deploy on windows steps * correct minor * change suggestions by @avaidyanatha

GitBook: [master] 161 pages and 75 assets modified

a18b0e8

Display icons (#3140)

1f0c3c7

* Display icons * Improve icons views

Merge remote-tracking branch 'origin/master' into htrueman/source-ite…

3f31a30

…rable-update-to-cdk

htrueman requested review from keu and sherifnada May 17, 2021 13:40

masonwheeler and others added 10 commits May 17, 2021 09:54

MS SQL Server Destination implementation

a67c769

Fixes issue #613. Normalization is not yet enabled. This will have to be added at a later point.

Workflow to handle operations (custom transformation) (#3379)

083aebc

* Keep normalization backward compatible with old settings from destination * Bumpversion normalization image

add npm install before all npm run generates' (#3442)

6beb4eb

restart containers if they fail automatically (#3423)

42ecf1f

Update link for contribution scheduling (#3443)

5f4485a

Address issue with icon in onboarding (#3437)

2e35fa4

rename toy connector tutorial to "Build a connector the hard way" (#3421

137845a

)

Upload test reports (from integration test slash commands) as GitHub …

1e8fa3a

…artifacts (#3416) * Archive test reports in github workflow * Archive Test reports only when failures

Fixing SqlServerOperations.java (#3454)

d2ce1d5

Fixing some issues with `SqlServerOperations`, which was out of sync with recent changes to `SqlOperations`.

Add redirect to cdk tutorial page (#3456)

0c11b27

* add redirect to cdk tutorial page * change path to cdk README.md

keu approved these changes May 18, 2021

View reviewed changes

htrueman added 2 commits May 18, 2021 17:28

Merge remote-tracking branch 'origin/master' into htrueman/source-ite…

cb8eb7f

…rable-update-to-cdk

Merge branch 'htrueman/source-iterable-update-to-cdk'

d626ac4

htrueman merged commit 588553e into master May 18, 2021

htrueman deleted the htrueman/source-iterable-update-to-cdk branch May 18, 2021 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Iterable: update to use latest version of CDK #3378

Source Iterable: update to use latest version of CDK #3378

htrueman commented May 12, 2021 •

edited

Loading

sherifnada left a comment

keu commented May 12, 2021 •

edited

Loading

keu left a comment

htrueman commented May 13, 2021 •

edited by github-actions bot

Loading

htrueman commented May 13, 2021 •

edited by github-actions bot

Loading

keu commented May 13, 2021

sherifnada left a comment

htrueman commented May 16, 2021 •

edited by github-actions bot

Loading

htrueman commented May 17, 2021 •

edited by github-actions bot

Loading

keu left a comment

htrueman commented May 18, 2021 •

edited by github-actions bot

Loading

htrueman commented May 18, 2021 •

edited by github-actions bot

Loading

Source Iterable: update to use latest version of CDK #3378

Source Iterable: update to use latest version of CDK #3378

Conversation

htrueman commented May 12, 2021 • edited Loading

What

Pre-merge Checklist

Recommended reading order

sherifnada left a comment

Choose a reason for hiding this comment

keu commented May 12, 2021 • edited Loading

keu left a comment

Choose a reason for hiding this comment

htrueman commented May 13, 2021 • edited by github-actions bot Loading

htrueman commented May 13, 2021 • edited by github-actions bot Loading

keu commented May 13, 2021

sherifnada left a comment

Choose a reason for hiding this comment

htrueman commented May 16, 2021 • edited by github-actions bot Loading

htrueman commented May 17, 2021 • edited by github-actions bot Loading

keu left a comment

Choose a reason for hiding this comment

htrueman commented May 18, 2021 • edited by github-actions bot Loading

htrueman commented May 18, 2021 • edited by github-actions bot Loading

htrueman commented May 12, 2021 •

edited

Loading

keu commented May 12, 2021 •

edited

Loading

htrueman commented May 13, 2021 •

edited by github-actions bot

Loading

htrueman commented May 13, 2021 •

edited by github-actions bot

Loading

htrueman commented May 16, 2021 •

edited by github-actions bot

Loading

htrueman commented May 17, 2021 •

edited by github-actions bot

Loading

htrueman commented May 18, 2021 •

edited by github-actions bot

Loading

htrueman commented May 18, 2021 •

edited by github-actions bot

Loading