Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Google Analytics Data API: Add CohortSpec to custom report in specification #33802

Merged
merged 11 commits into from
Jan 4, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Dec 27, 2023

What

Resolve

How

  • Add CohortSpec to custom report in specification
  • update docs

image

image

Recommended reading order

  1. spec.json

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 9:09pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 27, 2023
Copy link
Contributor

github-actions bot commented Dec 27, 2023

Warning

🚨 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master.

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 self-assigned this Dec 27, 2023
@artem1205 artem1205 linked an issue Dec 27, 2023 that may be closed by this pull request
@artem1205 artem1205 changed the title Source Google Analytics Data API: add cohortSpec to custom report in … 🐛 Source Google Analytics Data API: add cohortSpec to custom report in … Dec 27, 2023
@artem1205 artem1205 changed the title 🐛 Source Google Analytics Data API: add cohortSpec to custom report in … 🐛 Source Google Analytics Data API: Add CohortSpec to custom report in specification Dec 27, 2023
@artem1205
Copy link
Collaborator Author

artem1205 commented Dec 27, 2023

UI issue:

image
image

Cohorts should be shown separately, as described in schema.

Moving to on hold

UPDATE: used "oneOf" statement for better UX and overcome current rendering limitations.

@artem1205 artem1205 marked this pull request as ready for review December 28, 2023 19:06
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 28, 2023 19:07
@artem1205 artem1205 merged commit ce84d11 into master Jan 4, 2024
24 of 26 checks passed
@artem1205 artem1205 deleted the codefreeze-23-12/source-google-analytics-data-api branch January 4, 2024 16:19
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-data-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Google Analytics 4: Custom reports missing CohortSpec
3 participants