Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Amazon Ads: add region to inputOAuthConfiguration #33833

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Source Amazon Ads: add region to inputOAuthConfiguration #33833

merged 5 commits into from
Jan 5, 2024

Conversation

roman-yermilov-gl
Copy link
Contributor

What

https://github.com/airbytehq/oncall/issues/3755

How

Updated oauth configuration to put region to inputOAuthConfiguration

@roman-yermilov-gl roman-yermilov-gl self-assigned this Dec 28, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 11:21pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Dec 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 28, 2023 •
edited
Loading

Warning

🚨 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 28, 2023 •
edited by roman-yermilov-gl
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review December 28, 2023 16:24
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 28, 2023 16:25
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 28, 2023
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-amazon-ads-fix-oauth-input-params branch 2 times, most recently from bca408e to 154fd25 Compare December 28, 2023 17:39
lazebnyi
lazebnyi reviewed Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a PR for Java part of OAuth flow?

@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 3, 2024 10:45
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jan 3, 2024 •
edited
Loading

Do you have a PR for Java part of OAuth flow?

Yes. That PR was merged. This is a second part related to connector

@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-amazon-ads-fix-oauth-input-params branch from b5b3cef to 5a30262 Compare January 4, 2024 23:21
@roman-yermilov-gl roman-yermilov-gl enabled auto-merge (squash) January 4, 2024 23:28
@roman-yermilov-gl roman-yermilov-gl merged commit 7fab6e8 into master Jan 5, 2024
25 of 26 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-amazon-ads-fix-oauth-input-params branch January 5, 2024 00:05
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
Source Amazon Ads: add region to inputOAuthConfiguration (airbytehq#3…
4ce7559 
…3833)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
Source Amazon Ads: add region to inputOAuthConfiguration (airbytehq#3…
1584917 
…3833)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
Source Amazon Ads: add region to inputOAuthConfiguration (airbytehq#3…
a446336 
…3833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@alafanechere alafanechere Awaiting requested review from alafanechere

@brianjlai brianjlai Awaiting requested review from brianjlai

Assignees

@roman-yermilov-gl roman-yermilov-gl

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roman-yermilov-gl @lazebnyi @octavia-squidington-iii