Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Tutorials formatting + from scratch connector tutorial cleanup #33839

Merged
merged 20 commits into from Mar 7, 2024

Conversation

natikgadzhi
Copy link
Contributor

@natikgadzhi natikgadzhi commented Dec 29, 2023

What

This is a follow-up for #33822. It formats tutorials/**/*.md as an experiment with Prettier, and moves the onboarding "build connnector the hard way" tutorial in it's own subdirectory, and fixes a few inconsistencies.

Why

I'm not strongly attached to markdown linting and formatting, but I would love to make things nicer for us overall, and I see quite a lot of work that we can do to make both writing, maintaining, and contributing to Airbyte documentation a better experience.

How

Next steps

Content changes in Tutorials

  • I have my eyes on Tutorials, specifically airbytehq/airbyte-internal-issues#2382. Moving and cleaning tutorials is something I can do because I'll use the low-code CDK next. Plus, that way I will learn more about our documentation infrastructure.

Housekeeping in Docs

  • We have quite a lot of outdated deps, and one of them registers on Dependabot security list (Babel). Docs: Upgrading to latest Babel, PostCSS plugins, etc #33840
  • We should then add a markdown linter to have a list of pages to add front matter fields to, like summary.
  • Content cleanup would also be good. Some tutorials still link to assets in .gitbook.

natikgadzhi and others added 17 commits December 26, 2023 17:53
- Updated the python code samples to be valid (introduce log_error
  earlier)
- Updated the acceptance test documentation to `airbyte-ci`.
This commit renames Standard Tests mentions to Connector Acceptance
Tests in the python souce connector tutorial.
- Fixed a typo
- Removed redundant git manipulations
- Clarified Generic Source template usage
- Linked Python CDK docs.
- Reworded the contributions warning.
- Made a clickable link to the community Slack channel
- General formatting cleanup
- Updated the link to examples (exchanges API migrated to low code)
- Updated Python CDK readme to match it's docs
  (docs/connector-development/cdk-python/README.md)
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
- This commit just runs prettier against all files in `tutorials`.
- Also, fixed admonition styles (`:::info`) where prettier broke them.
- And fixed a connector testing step to refer to CATS
@natikgadzhi natikgadzhi added area/documentation Improvements or additions to documentation team/documentation labels Dec 29, 2023
@natikgadzhi natikgadzhi self-assigned this Dec 29, 2023
@natikgadzhi natikgadzhi requested a review from a team as a code owner December 29, 2023 05:33
Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 4:13am

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Dec 29, 2023
Copy link
Contributor

Warning

Soft code freeze is in effect until 2024-01-02. Please avoid merging to master. #freedom-and-responsibility

@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Jan 3, 2024
@@ -2,24 +2,26 @@

## Summary

This article provides a checklist for how to create a Java destination. Each step in the checklist has a link to a more detailed explanation below.
This article provides a checklist for how to create a Java destination. Each step in the checklist
has a link to a more detailed explanation below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the line break?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely a prettier -w pass with 100 desired line width. I'm not strongly attached to this approach — I personally like linted markdown to comply to certain width, especially when there are a lot of contibutors, but functionally, same thing.

@natikgadzhi
Copy link
Contributor Author

Caveat: when we merge this, I need to update the engineering onboarding check-list, because it links to the old the-hard-way guide URL.

Also, consider making them linked to the sidebar again.

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@@ -1,22 +1,29 @@
# Step 8: Test Connector
# Step 8: Test the Connector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should the file name be test-the-connector.md?

@marcosmarxm
Copy link
Member

@natikgadzhi let's ship this one?

@natikgadzhi natikgadzhi enabled auto-merge (squash) March 7, 2024 04:09
@natikgadzhi natikgadzhi merged commit e4ccffb into master Mar 7, 2024
26 checks passed
@natikgadzhi natikgadzhi deleted the natikgadzhi/docs/formatting branch March 7, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation team/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants