Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰Source Hubspot: fix property_history PK #33844

Merged

Conversation

roman-yermilov-gl
Copy link
Collaborator

What

Missed records during Incremental/Deduped sync. This is happened because history records are unnested data which belong to particular entity and don't have their own id. Instead they have only entity id which apper to be not unique in this situation.

How

Make PK combined from entity id, property name and timestamp

@roman-yermilov-gl roman-yermilov-gl self-assigned this Dec 29, 2023
Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview Dec 29, 2023 9:43pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Dec 29, 2023
Copy link
Contributor

github-actions bot commented Dec 29, 2023

Warning

馃毃 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master.

Copy link
Contributor

github-actions bot commented Dec 29, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 29, 2023
@roman-yermilov-gl roman-yermilov-gl changed the title Source Hubspot: fix property_history PK 馃悰Source Hubspot: fix property_history PK Dec 29, 2023
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review December 29, 2023 15:59
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 29, 2023 16:00
@artem1205
Copy link
Collaborator

@roman-yermilov-gl , changing the Primary key should be treated as breaking change ?

@roman-yermilov-gl roman-yermilov-gl merged commit f8f6438 into master Jan 8, 2024
26 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-hubspot-fix-property-history-pk branch January 8, 2024 20:43
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants