New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰Source Hubspot: fix property_history PK #33844
馃悰Source Hubspot: fix property_history PK #33844
Conversation
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
Warning 馃毃 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master. |
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 馃帀 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@roman-yermilov-gl , changing the Primary key should be treated as breaking change ? |
What
Missed records during Incremental/Deduped sync. This is happened because history records are unnested data which belong to particular entity and don't have their own id. Instead they have only entity id which apper to be not unique in this situation.
How
Make PK combined from entity id, property name and timestamp