Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination-redshift: Fix StackOverflowError with eager rendering of nested jooq function call sql. #33877

Merged
merged 5 commits into from Jan 3, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 3, 2024

What

Fixes #33759

How

Building the recursive function() doesn't seem to be the problem, the StackOverflowError happens at 2000 columns, which is arbitrary depending on the Stack Size allocated by JVM (which can be increased by -Xms). The problem seems to be lurking in how the SQL string rendering happens where function(...function(... nested references are creating StackOverflowError. Fix is to render the SQL at every step of nesting to avoid deep stack.

@gisripa gisripa requested a review from a team as a code owner January 3, 2024 05:24
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 7:40pm

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to update the arrayConcatStmt javadoc to say it's not recursive :P

@gisripa gisripa changed the title Reproduced StackOverflow with unittest. destination-redshift: Fix StackOverflowError with eager rendering of nested jooq function call sql. Jan 3, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 3, 2024
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
@gisripa gisripa force-pushed the gireesh/redshift/jooq-soerror branch from 6117010 to 4a9b2b3 Compare January 3, 2024 19:38
@gisripa gisripa enabled auto-merge (squash) January 3, 2024 19:39
@gisripa gisripa merged commit 0cebfbf into master Jan 3, 2024
21 checks passed
@gisripa gisripa deleted the gireesh/redshift/jooq-soerror branch January 3, 2024 20:11
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…nested jooq function call sql. (airbytehq#33877)

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…nested jooq function call sql. (airbytehq#33877)

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…nested jooq function call sql. (airbytehq#33877)

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/destination/redshift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redshift v2: jooq StackOverflowError
3 participants