-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AirbyteLib example notebook with source-faker
#33878
AirbyteLib example notebook with source-faker
#33878
Conversation
…into flash1293/airbyte-lib
improve sql handling, add duckdb and pgsql poetry init cleanup imports add pandas option delete stale file set parquet config class Merge 'origin/flash1293/airbyte-lib' into aj/airbyt-lib-caches update deps move all non-public methods to be protected members consolidate public interface in code file delete files from missing .gitignore rules decouple file writers from caches mypy fixes, refactor filewriters, cleanup finalize_batches implementation
improve sql handling, add duckdb and pgsql poetry init cleanup imports add pandas option delete stale file set parquet config class Merge 'origin/flash1293/airbyte-lib' into aj/airbyt-lib-caches update deps move all non-public methods to be protected members consolidate public interface in code file delete files from missing .gitignore rules decouple file writers from caches mypy fixes, refactor filewriters, cleanup finalize_batches implementation cleanup sql cache implementation
@aaronsteers looks like you had a bad merge here. You'll need to rebase |
…ttps://github.com/airbytehq/airbyte into aj/airbyte-lib/example-notebook-with-source-faker
…ple-notebook-with-source-faker
… aj/airbyte-lib/example-notebook-with-source-faker
@flash1293 and @alafanechere Thank you both for your feedback here on this PR. My plan is to split this into a few different places:
I'll note also that I don't have full context on the action items in this comment regarding Update:
|
We discussed with @flash1293 that this will be addressed once the |
Closing. See this comment from above for spin-off PRs: |
This adds a working example notebook and source-faker as a source. Also fixes bugs discovered during execution of the sample source.
Should merge after: