Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'dev' sentry environment for airbyte-ci pipx installs in PRs #33920

Merged
merged 10 commits into from
Jan 4, 2024

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Jan 3, 2024

Use different sentry environments based on how we install Airbyte CI in PRs so that we can configure our alerting and sort our open issues on sentry.

After changing our slack alerts (still not sure why we have 2 different ones) explicitly to alert for the production environment (which is what all of our issues are being sent to currently), a new dev alert was not posted to slack.

Closes #33892

@erohmensing erohmensing requested a review from a team January 3, 2024 21:23
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 10:54pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@erohmensing erohmensing marked this pull request as draft January 3, 2024 21:31
@erohmensing erohmensing marked this pull request as ready for review January 3, 2024 22:53
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just beautiful.

@@ -101,6 +101,17 @@ runs:
pipelines:
- 'airbyte-ci/connectors/pipelines/**'

- name: Determine how Airbyte CI should be installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this addition 😍

@erohmensing erohmensing merged commit 14af598 into master Jan 4, 2024
24 of 25 checks passed
@erohmensing erohmensing deleted the ella/no-dev-sentry branch January 4, 2024 15:13
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airbyte-ci: don't report sentry issues on dev branches
3 participants