Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata service steps #33981

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Jan 5, 2024

Problem

We use arrays to denote concurrency

e.g.

steps = [
  [1a, 1b, 1c],
  [2a, 2b, 2c],
  ]

and the orchestrator deploy steps were defined concurrently when they needed to be sequential.

Solution

  1. Update to use the array
  2. Throw a better error message
  3. Add tests
  4. Open discussion on if we should use something more explicit than an array structure

@bnchrch bnchrch requested a review from a team January 5, 2024 18:41
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 7:47pm

@erohmensing erohmensing merged commit e9d5377 into master Jan 5, 2024
19 checks passed
@erohmensing erohmensing deleted the bnchrch/fix-metadata-service-steps branch January 5, 2024 19:59
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: erohmensing <erohmensing@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: erohmensing <erohmensing@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: erohmensing <erohmensing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants