Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Source Instagram: remove metrics from video feed #33989

Merged
merged 4 commits into from Jan 8, 2024

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jan 6, 2024

What

The metrics requested for "media_product_type" == "FEED and "media_type" == "VIDEO" are crashing syncs. The error is (#100) Incompatible metric (total_interactions) with the media

How

Excluding total_interactions, impressions, likesandcomments`

馃毃 User Impact 馃毃

We should hopefully see sync with video reel working again

Copy link

vercel bot commented Jan 6, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview Jan 6, 2024 11:36pm

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@maxi297 maxi297 changed the title have specific metrics for video feed 馃悰 Source Instagram: remove metrics from video feed Jan 6, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 6, 2024 21:25
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 6, 2024
@maxi297 maxi297 added checklist-action-run and removed area/documentation Improvements or additions to documentation checklist-action-run labels Jan 6, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 6, 2024
@maxi297 maxi297 merged commit 1359d7b into master Jan 8, 2024
27 checks passed
@maxi297 maxi297 deleted the maxi297/fix-instagram branch January 8, 2024 12:18
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants