Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-lib: Validation helper command #34002

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

flash1293
Copy link
Contributor

This PR adds a helper command airbyte-lib-validate-source, which can be used to validate whether a python package can be called as a source connector via airbyte-lib.

This is meant as a smoke test to validate that airbyte-lib specific entrypoints are set up correctly, not whether the connector fully adheres to the Airbyte protocol - for this, the regular CATs should be used.

In a separate PR, this logic will be used as part of the airbyte-ci test command to validate connectors that are whitelisted to be published to pypi.

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 0:25am

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

One minor suggestion regarding file-level docstring.

airbyte-lib/airbyte_lib/validate.py Outdated Show resolved Hide resolved
@flash1293 flash1293 merged commit 923331c into master Jan 9, 2024
19 checks passed
@flash1293 flash1293 deleted the flash1293/airbyte-lib-testing-helper branch January 9, 2024 12:43
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants