Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Ads: Convert to airbyte-lib #34007

Merged
merged 10 commits into from
Jan 16, 2024
11 changes: 2 additions & 9 deletions airbyte-integrations/connectors/source-google-ads/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,7 @@
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#


import sys

from airbyte_cdk.entrypoint import launch
from source_google_ads import SourceGoogleAds
from source_google_ads.config_migrations import MigrateCustomQuery
from source_google_ads.run import run

if __name__ == "__main__":
source = SourceGoogleAds()
MigrateCustomQuery.migrate(sys.argv[1:], source)
launch(source, sys.argv[1:])
run()
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
dockerImageTag: 3.1.0
dockerImageTag: 3.1.1
dockerRepository: airbyte/source-google-ads
documentationUrl: https://docs.airbyte.com/integrations/sources/google-ads
githubIssueLabel: source-google-ads
Expand Down
5 changes: 5 additions & 0 deletions airbyte-integrations/connectors/source-google-ads/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
TEST_REQUIREMENTS = ["pytest~=6.1", "pytest-mock", "freezegun", "requests-mock"]

setup(
entry_points={
"console_scripts": [
"source-google-ads=source_google_ads.run:run",
],
},
name="source_google_ads",
description="Source implementation for Google Ads.",
author="Airbyte",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#


import sys

from airbyte_cdk.entrypoint import launch
from source_google_ads import SourceGoogleAds
from source_google_ads.config_migrations import MigrateCustomQuery


def run():
source = SourceGoogleAds()
MigrateCustomQuery.migrate(sys.argv[1:], source)
launch(source, sys.argv[1:])
1 change: 1 addition & 0 deletions docs/integrations/sources/google-ads.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ Due to a limitation in the Google Ads API which does not allow getting performan

| Version | Date | Pull Request | Subject |
|:---------|:-----------|:---------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------|
| `3.1.1` | 2024-01-10 | [34007](https://github.com/airbytehq/airbyte/pull/34007) | prepare for airbyte-lib |
| `3.1.0` | 2024-01-09 | [33603](https://github.com/airbytehq/airbyte/pull/33603) | Fix two issues in the custom queries: automatic addition of `segments.date` in the query; incorrect field type for `DATE` fields. |
| `3.0.2` | 2024-01-08 | [33494](https://github.com/airbytehq/airbyte/pull/33494) | Add handling for 401 error while parsing response. Add `metrics.cost_micros` field to Ad Group stream. |
| `3.0.1` | 2023-12-26 | [33769](https://github.com/airbytehq/airbyte/pull/33769) | Run a read function in a separate thread to enforce a time limit for its execution |
Expand Down