airbyte-ci: fix nightly build binary #34022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
erohmensing
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Had to dig a little bit to understand this, but now it makes sense - inputs is only available on the workflow_dispatch trigger and not on the cron trigger. Instead we won't set it, since this will call the ./.github/actions/run-dagger-pipeline action which already has it as an optional input with a default (since it is an action, the default will actually be filled) - sort of confusing how these are ever so slightly different
alafanechere
deleted the
augustin/01-08-airbyte-ci_fix_nightly_build_binary
branch
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #34040
How
The
airbyte-ci-binary-urlinput was introduced as a workflow dispatch input for manual testing purposes, without a default fallback on schedule.We can remove this input as: