[mitigation] pin airbyte ci version in master run #34075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@alafanechere if this makes sense, feel free to merge while I'm still offline! Would love to make sure format keeps running on master |
bnchrch
approved these changes
Jan 10, 2024
|
Master is still green formatting-wise (against the pinned version of airbyte ci, anyway 👍🏻) https://github.com/airbytehq/airbyte/actions/runs/7468664369/job/20324511990 |
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format is not running on master - it is failing and returning success.
This is because the pinned mitigation version is not set as it is for workflow dispatch and pull request setups.
The step fails on master at the moment, with this error that sounds about right (as we are trying to run dagger 0.9.x code on a 0.6.x runner)
The action returns success - not sure why.
Note that this same error appears on PRs touching airbyte-ci since we install the latest airbyte-ci on the branch - issue for that here.