Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Google Ads: Disable raising error for not enabled accounts #34200

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Jan 12, 2024

What

Following the 3.2.0 update, users with access to non-enabled accounts began encountering failures due to an error. To resolve this issue, I have disabled the exception that was being raised for this specific error scenario. Resolves: https://github.com/airbytehq/oncall/issues/3943

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 10:35am

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 12, 2024
@tolik0 tolik0 requested a review from a team January 12, 2024 09:34
@tolik0 tolik0 self-assigned this Jan 12, 2024
@tolik0 tolik0 marked this pull request as ready for review January 12, 2024 09:35
@tolik0 tolik0 requested review from a team and removed request for a team January 12, 2024 09:50
@tolik0 tolik0 force-pushed the tolik0/source-google-ads/fix-3-2-0-error branch from 1f7c2f6 to 9732485 Compare January 12, 2024 10:35
@tolik0 tolik0 merged commit c967f14 into master Jan 12, 2024
24 checks passed
@tolik0 tolik0 deleted the tolik0/source-google-ads/fix-3-2-0-error branch January 12, 2024 10:58
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants