Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: upgrade to dagger 0.9.6 #34321

Merged

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 17, 2024

What

Closes #34110
Closes #34041
We want to use the latest dagger version in our pipelines and other internal packages using dagger

How

  • Create new 0.9.6 runners on the infra (https://github.com/airbytehq/airbyte-infra/pull/90)
  • Bump dagger version in pyproject.toml of pipelines, cat, base_images + regenerate lock files
  • Add 0.9.6 to supported version in the infra in pipelines
  • Bump packages version

Manual testing

User impact

You can note that no workflow file change is required to propagate this upgrade. New runners are dynamically targetted thanks to the new get_ci_runner job, infering the runner from the airbyte-ci command.
So no "please update your branch" is required 馃槃 :

  • 0.9.5 will continue to be used until we merge this PR.
  • On merge a new airbyte-ci binary using 0.9.6 will be released.
  • The --ci-requirements on the jobs using the latest binary will output that 0.9.6 runners have to be used.
  • The PRs not up to date with master will still use the latest airbyte-ci binary so pulling master in is not required.

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview Jan 18, 2024 2:25pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere marked this pull request as ready for review January 18, 2024 06:58
@alafanechere alafanechere requested a review from a team January 18, 2024 06:58
@alafanechere alafanechere force-pushed the augustin/01-17-airbyte-ci_upgrade_to_dagger_0.9.6 branch from 4708c56 to 5064719 Compare January 18, 2024 07:13
@alafanechere alafanechere enabled auto-merge (squash) January 18, 2024 12:22
@alafanechere alafanechere force-pushed the augustin/01-17-airbyte-ci_upgrade_to_dagger_0.9.6 branch from 5064719 to 02e8d9f Compare January 18, 2024 14:25
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: in all the places that we refer to "we use dagger" in the docs, we link to the 0.6.4 docs - we should update this.

Otherwise LGTM, hoping this does the trick!

@alafanechere alafanechere merged commit 5f35187 into master Jan 18, 2024
26 checks passed
@alafanechere alafanechere deleted the augustin/01-17-airbyte-ci_upgrade_to_dagger_0.9.6 branch January 18, 2024 16:16
@evantahler
Copy link
Contributor

Note to future self: This is a good dagger version upgrade reference PR for when want to update the dagger runner infrastructure versions again (SEO words)!

jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dagger 0.9.6 when released airbyte-ci : format TransportError: Unexpected response from engine
3 participants