🎉 New Source: Google Analytics v4 Service Account Only

[artem1205]

What

Resolve #34258

How

enable in Cloud

Recommended reading order

1. airbyte-integrations/connectors/source-google-analytics-v4-service-account-only/metadata.yaml

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Connector version is set to 0.0.1
  • Dockerfile has version 0.0.1
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
  • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Jan 29, 2024 4:09pm

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[evantahler]

Rather than make a whole new connector, which adds test and maintenance burden, I would suggest keeping just one connector and checking if we are running on cloud via environment variable. If we are running on cloud, don't offer the oAuth option.

cc @erohmensing, who has recently removed some of our strict-encrypt connectors, which are are similar sort of pattern - we had cloud-only connectors with a only a subtle auth or config change.

[alafanechere]

+1 for @evantahler suggestion.
Adding a connector variant with inter connector dependency is additional maitainance and release flow complexity on our team end.
Let us know if you have a strong reason to not use the DEPLOYMENT_MODE env var (which will be set to cloud when running on cloud) to adapt this connector behavior.

[alafanechere]

Removing my request changes following discussion in this thread.
There might be additional work to consider on airbyte-ci in order to automatically publish the new connector when source-google-analytics-v4 changes.

Discussed in https://airbytehq-team.slack.com/archives/C02U9R3AF37/p1705594521435559

[artem1205]

@katmarkham , PR is ready, when would you like to deploy it?

[katmarkham]

thanks for updating the name!