Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Destination typesense: Update check() to mitigate "check() takes 2 positional arguments but 3 were given" #34336

Merged
merged 5 commits into from Jan 19, 2024
Merged

🐛 Destination typesense: Update check() to mitigate "check() takes 2 positional arguments but 3 were given" #34336

merged 5 commits into from Jan 19, 2024

Conversation

jenssogaard
Copy link
Contributor

What

When adding typesense as a destination check() fails due to incorrect number of arguments #34331.

How

Support logger as 2nd argument in check() as all other destinations.

🚨 User Impact 🚨

Minor version bump. Should resolve #34331

Updating a connector

Community member or Airbyter

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 9:36pm

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 17, 2024
@marcosmarxm
Copy link
Member

Hello @jenssogaard can you sign the CLA or make sure the contribution was made by the same user?

marcosmarxm
marcosmarxm approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jenssogaard

@marcosmarxm marcosmarxm merged commit 86f3c7d into airbytehq:master Jan 19, 2024
44 of 50 checks passed
@jenssogaard
Copy link
Contributor Author

Thanks @jenssogaard

Awesome. Happy to contribute.

jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@jenssogaard @marcosmarxm @jatinyadav-cc
🐛 Destination typesense: Update check() to mitigate "check() takes 2 …
063e2c8 
…positional arguments but 3 were given" (airbytehq#34336)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@jenssogaard @marcosmarxm @jatinyadav-cc
🐛 Destination typesense: Update check() to mitigate "check() takes 2 …
cb8bf81 
…positional arguments but 3 were given" (airbytehq#34336)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@jenssogaard @marcosmarxm @jatinyadav-cc
🐛 Destination typesense: Update check() to mitigate "check() takes 2 …
4b0220a 
…positional arguments but 3 were given" (airbytehq#34336)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/typesense
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

destination-typesense: Configuration check failed -> check() takes 2 positional arguments but 3 were given
4 participants
@jenssogaard @CLAassistant @marcosmarxm @octavia-squidington-iii