update airbyte-ci bump-version to push more minimal changes #34339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/01-17-update_airbyte-ci_bump-version_to_push_more_minimal_changes
branch
from
a812a10
to
eb63012
Compare
stephane-airbyte
force-pushed
the
stephane/01-17-update_airbyte-ci_bump-version_to_push_more_minimal_changes
branch
2 times, most recently
from
a7d3cdc
to
45165a8
Compare
alafanechere
requested changes
Jan 19, 2024
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/bump_version/pipeline.py
Outdated
Show resolved
Hide resolved
| updated_metadata = self.get_metadata_with_bumped_version(current_version, self.new_version, current_metadata) | ||
| repo_dir_with_updated_metadata = metadata_change_helpers.get_repo_dir_with_updated_metadata( | ||
| self.repo_dir, metadata_path, updated_metadata | ||
| updated_metadata_str = self.get_metadata_with_bumped_version(current_version, self.new_version, current_metadata_str) |
There was a problem hiding this comment.
I totally get the reason why you mutate the metadata as string and not yaml: preserving order and comment.
I would suggest adding a yaml.safe_load(current_metadata_step) step without assignation to make sure the yaml is still valid.
Or even better: run a MetadataValidation step..
FYI I think this python yaml package can preserve comment and order, but I never tried it
There was a problem hiding this comment.
the call to get_current_metadata should already do that. We can't get the version number without having parsed the json succesfully.
Unless you meant that I need to run validation against the update_metadata_str ?
There was a problem hiding this comment.
Unless you meant that I need to run validation against the update_metadata_str ?
Yes this is what I meant
stephane-airbyte
force-pushed
the
stephane/01-17-update_airbyte-ci_bump-version_to_push_more_minimal_changes
branch
2 times, most recently
from
c570cff
to
837a63b
Compare
stephane-airbyte
force-pushed
the
stephane/01-17-update_airbyte-ci_bump-version_to_push_more_minimal_changes
branch
from
837a63b
to
131861c
Compare
alafanechere
approved these changes
Jan 23, 2024
…ion_to_push_more_minimal_changes
stephane-airbyte
deleted the
stephane/01-17-update_airbyte-ci_bump-version_to_push_more_minimal_changes
branch
Merge activity
|
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…q#34339) I noticed that `airbyte-ci connectors bump-version ` changes more things than necessary. In particular, it reserialize json, which means we were losing comments and reordering the various keys. I moved to doing a search-and-replace. In addition, I also noticed that the changelog changes could be slightly improved: I'm not increasing the space for the version (so we can accomodate 0.21.53, or 0.125.2), and adding a new line at the end of the file (which was flagged as a difference by `diff`
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…q#34339) I noticed that `airbyte-ci connectors bump-version ` changes more things than necessary. In particular, it reserialize json, which means we were losing comments and reordering the various keys. I moved to doing a search-and-replace. In addition, I also noticed that the changelog changes could be slightly improved: I'm not increasing the space for the version (so we can accomodate 0.21.53, or 0.125.2), and adding a new line at the end of the file (which was flagged as a difference by `diff`
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…q#34339) I noticed that `airbyte-ci connectors bump-version ` changes more things than necessary. In particular, it reserialize json, which means we were losing comments and reordering the various keys. I moved to doing a search-and-replace. In addition, I also noticed that the changelog changes could be slightly improved: I'm not increasing the space for the version (so we can accomodate 0.21.53, or 0.125.2), and adding a new line at the end of the file (which was flagged as a difference by `diff`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
airbyte-ci connectors bump-versionchanges more things than necessary. In particular, it reserialize json, which means we were losing comments and reordering the various keys. I moved to doing a search-and-replace. In addition, I also noticed that the changelog changes could be slightly improved: I'm not increasing the space for the version (so we can accomodate 0.21.53, or 0.125.2), and adding a new line at the end of the file (which was flagged as a difference bydiff