airbyte-lib snowflake integration #34356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
added 2 commits
January 19, 2024 15:00
…q/airbyte into flash1293/airbyte-lib-snowflake
added 2 commits
January 19, 2024 15:05
rodireich
pushed a commit
that referenced
this pull request
Jan 19, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Snowflake support to airbyte-lib.
Changes to enable Snowflake support
As the snowflake sqlalchemy plugin doesn't support sqlalchemy 2, I downgraded to the last version of sqlalchemy 1. IMHO having a slightly outdated version of sqlalchemy is less important than snowflake support. We should check with the Snowflake team whether they are working on upgrading, and we can follow up. This changes some imports in our base class but no major changes were necessary, which makes me think this is OK.
To make the postgres adapter work, I had to add the
psycopg2==2.9.9dependency.I'm not sure how to implement merge-support for snowflake, so for now the snowflake cache defaults to
appendinstead of overwrite. This should probably be adjusted before release, but I wanted to keep this PR minimal to make the basic functionality work.Testing
To test the snowflake support, the following setup is used: