notifications service #3438
notifications service #3438
Conversation
| const interval = setInterval(async () => { | ||
| try { | ||
| await healthService.health(); | ||
| if (count >= 3) { |
There was a problem hiding this comment.
is there a reason we wouldn't always just unregister (even if the count is less than 3)? eh. i guess i can see why this would be wasteful.
also can you make the 3 a constant, so that if in the future we change one, we don't forget to change the other?
There was a problem hiding this comment.
Yeah, we do not need to unregister, because it won't be there yet.
Good idea to change it into constant: should it be part of config or just const above is enough? FYI interval is part of config.
| try { | ||
| result = await response.json(); | ||
| } catch (e) { | ||
| // |
There was a problem hiding this comment.
should there be a comment here?
There was a problem hiding this comment.
As I remember eslint does not allow empty braces, so I put comment here. May add more meaningful name
| } | ||
|
|
||
| if (result?.error) { | ||
| if (result.error.startsWith("Version mismatch between")) { |
There was a problem hiding this comment.
I'm going to create an issue for the API to standardize the schema of its error messages. I agree with your choice here for now, but would like to have things be a bit more structured in the future, but the API has to lead on this.
There was a problem hiding this comment.
Exactly! Totally forgot to ask also send some sort of id for errors. But we could update it later
| const interval = setInterval(async () => { | ||
| try { | ||
| await healthService.health(); | ||
| if (count >= 3) { |
There was a problem hiding this comment.
Yeah, we do not need to unregister, because it won't be there yet.
Good idea to change it into constant: should it be part of config or just const above is enough? FYI interval is part of config.
| try { | ||
| result = await response.json(); | ||
| } catch (e) { | ||
| // |
There was a problem hiding this comment.
As I remember eslint does not allow empty braces, so I put comment here. May add more meaningful name
| } | ||
|
|
||
| if (result?.error) { | ||
| if (result.error.startsWith("Version mismatch between")) { |
There was a problem hiding this comment.
Exactly! Totally forgot to ask also send some sort of id for errors. But we could update it later
What
Closes #2773
Closes #2152
Closes #1495
Added
Closes #2595
How
All these 3 tasks are done as part of 1 task because they share same notifications service concept.
For
show when the UI is disconnected from the API serverwe poll server/healthevery 10 seconds. After 3 unsuccessful checks - we display a notification about an error.Includes changes that move control and some base components to separate directory
components->components/base.Common Error concept
NetworkErrorBoundarytoApiErrorBoundarythat is responsible for displaying common screen in case of errors.ServerIsStartingcomponent )┆Issue is synchronized with this Asana task by Unito