New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Typeform: Fix pagination stop condition #34484
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…7' into artem1205/source-typeform-OC-4047 # Conflicts: # docs/integrations/sources/typeform.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, can you add more details about reson and solution for issue
What
https://github.com/airbytehq/oncall/issues/4047
How
fix pagination stop condition
response['total_items']
somehow (was unable to reproduce) was not zero, and connector tried to extract next_page_token fromlast_records
, which were empty. To be more consistent stop_condition is defined as check forlen(last_records)
Recommended reading order
airbyte-integrations/connectors/source-typeform/source_typeform/manifest.yaml
🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.