Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Typeform: Fix pagination stop condition #34484

Merged
merged 3 commits into from Jan 24, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Jan 24, 2024

What

https://github.com/airbytehq/oncall/issues/4047

How

fix pagination stop condition

response['total_items'] somehow (was unable to reproduce) was not zero, and connector tried to extract next_page_token from last_records, which were empty. To be more consistent stop_condition is defined as check for len(last_records)

Recommended reading order

  1. airbyte-integrations/connectors/source-typeform/source_typeform/manifest.yaml

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 3:06pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/typeform labels Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 changed the title Source Typeform: fix pagination stop condition 🐛 Source Typeform: Fix pagination stop condition Jan 24, 2024
…7' into artem1205/source-typeform-OC-4047

# Conflicts:
#	docs/integrations/sources/typeform.md
@artem1205 artem1205 marked this pull request as ready for review January 24, 2024 15:09
@artem1205 artem1205 self-assigned this Jan 24, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 24, 2024 15:10
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you add more details about reson and solution for issue

@artem1205 artem1205 merged commit c3e4a7c into master Jan 24, 2024
33 checks passed
@artem1205 artem1205 deleted the artem1205/source-typeform-OC-4047 branch January 24, 2024 16:10
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/typeform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants