🐛 Destination snowflake: use 200MB batches #34502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
edgao
changed the title
edgao
commented
Jan 24, 2024
| @@ -37,16 +37,6 @@ class AsyncFlush implements DestinationFlushFunction { | |||
| private final long optimalBatchSizeBytes; | |||
| private final boolean useDestinationsV2Columns; | |||
|
|
|||
| public AsyncFlush(final Map<StreamDescriptor, WriteConfig> streamDescToWriteConfig, | |||
There was a problem hiding this comment.
this constructor was only ever called from the overload createAsync() method. Delete it.
edgao
force-pushed
the
edgao/snowflake/batch_size
branch
from
c819387
to
45962b6
Compare
octavia-squidington-iii
added
the
area/documentation
octavia-squidington-iii
removed
the
area/documentation
gisripa
reviewed
Jan 29, 2024
.../java/io/airbyte/integrations/destination/snowflake/SnowflakeInternalStagingDestination.java
Outdated
Show resolved
Hide resolved
gisripa
approved these changes
Jan 29, 2024
octavia-squidington-iii
added
the
area/documentation
|
/publish-java-cdk
|
|
/publish-java-cdk force=true
|
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31741
test sync running - https://cloud.airbyte.com/workspaces/b61bc266-ef3c-460c-af2f-f70da4a2993c/connections/a54f466c-83a6-40e7-ae86-6e79961040d5/job-history#7796162::0. Verified that it now has 200MB batches:
Previous syncs took 500 - 800 COPY statements for the 10M faker dataset; new syncs are taking around 70 COPYs. Total sync runtime is still a bit under 1 hour.
make the factory class more useful; add a builder. Move the 50MB default into the factory class.
new StagingConsumerFactory.Builder()sounds dumb, I'm open to naming suggestions 🤷