🐛 Source GitHub: Fix MultipleToken rotation logic

[artem1205]

What

Resolve https://github.com/airbytehq/oncall/issues/4135

How

Fix MultiToken rotation logic by:

1. requesting github endpoint and collect data about remaining available requests

Important

REST and GraphQL limits are counted separately

3. rotate token not for every request, but only after reaching the limits for current token. Reason: rate limit window resets in an hour after the very first requests (no matter how many requests were done afterwards). Thus means, that rotating tokens on every request will lead to faster reaching the limits on all available tokens.

Recommended reading order

1. airbyte-integrations/connectors/source-github/source_github/spec.json
2. airbyte-integrations/connectors/source-github/source_github/source.py
3. airbyte-integrations/connectors/source-github/source_github/streams.py
4. airbyte-integrations/connectors/source-github/source_github/utils.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 26, 2024 1:56pm

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ValueError: sleep length must be non-negative /airbyte/integration_code/source_github/utils.p... View Issue

_{Did you find this useful? React with a 👍 or 👎}