Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨🚨🐛 Source Gitlab fix merge_request_commits stream #34548

Merged
Merged
Show file tree
Hide file tree
Changes from 61 commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
bd8a4c8
Revert "updated Prerequisites"
midavadim Sep 21, 2023
56daf02
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Sep 27, 2023
8ad4061
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Oct 11, 2023
2cab1ff
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Oct 16, 2023
6aae53d
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Oct 19, 2023
e45624c
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Oct 23, 2023
c923aa9
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Oct 23, 2023
be763e2
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Oct 26, 2023
4883642
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Oct 26, 2023
3e2c793
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 1, 2023
d948037
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 6, 2023
4736e76
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 6, 2023
b4ef214
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 13, 2023
c0376ab
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 14, 2023
ed7dbd7
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 15, 2023
703880f
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 17, 2023
a22e333
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 17, 2023
cb00fc2
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 17, 2023
854f87d
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 20, 2023
c68a752
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Nov 24, 2023
d13e69f
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Dec 1, 2023
9795a7d
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Dec 12, 2023
8358894
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Dec 14, 2023
0b8ee3b
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Jan 5, 2024
7d55bad
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Jan 8, 2024
9fa8a29
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Jan 8, 2024
7cab07a
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Jan 9, 2024
85e72ed
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Jan 15, 2024
bdde638
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Jan 25, 2024
8aa89f7
fix merge_request_commits stream to return real commits
midavadim Jan 26, 2024
5262396
docs and migration guide
midavadim Jan 26, 2024
4838db4
fix SAT
midavadim Jan 26, 2024
5d6475f
format
midavadim Jan 26, 2024
6583c5d
SAT
midavadim Jan 26, 2024
23b7381
SAT
midavadim Jan 26, 2024
c7b2ca1
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 26, 2024
39d3e40
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 26, 2024
5b3ef30
updated major version
midavadim Jan 26, 2024
dcac2a8
Merge remote-tracking branch 'origin/midavadim/3864-source-gitlab-fix…
midavadim Jan 26, 2024
57f707e
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 30, 2024
0031711
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Jan 30, 2024
82fcde8
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 30, 2024
d1b9076
Merge remote-tracking branch 'origin/midavadim/3864-source-gitlab-fix…
midavadim Jan 30, 2024
1d33a8a
fix schemas
midavadim Jan 30, 2024
323d49d
fix schemas
midavadim Jan 30, 2024
7c392ce
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 30, 2024
40d9cee
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 30, 2024
c30ca2b
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 30, 2024
6882d08
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 30, 2024
052e382
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Jan 30, 2024
df92372
fixed version
midavadim Jan 30, 2024
4584325
Merge remote-tracking branch 'origin/midavadim/3864-source-gitlab-fix…
midavadim Jan 30, 2024
a97b4ee
updated migration guide
midavadim Feb 7, 2024
1397af9
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Feb 7, 2024
580693b
update projecs schema
midavadim Feb 7, 2024
acaab8b
Merge remote-tracking branch 'origin/midavadim/3864-source-gitlab-fix…
midavadim Feb 7, 2024
18a72bc
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Feb 7, 2024
ddb442d
update projects expected
midavadim Feb 7, 2024
8ce250b
Merge remote-tracking branch 'origin/midavadim/3864-source-gitlab-fix…
midavadim Feb 7, 2024
165f40d
update projects expected
midavadim Feb 7, 2024
2d6eb14
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Feb 7, 2024
cd2c611
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim Feb 7, 2024
47b9fd8
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Feb 7, 2024
b8bcbae
update projects expected
midavadim Feb 7, 2024
da70f1b
Merge remote-tracking branch 'origin/midavadim/3864-source-gitlab-fix…
midavadim Feb 7, 2024
68e1698
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Feb 15, 2024
33fddf4
added missing attrs for groups
midavadim Feb 15, 2024
04c7a4f
Merge remote-tracking branch 'origin/midavadim/3864-source-gitlab-fix…
midavadim Feb 15, 2024
15834ff
fixed records for pipelines_extended
midavadim Feb 15, 2024
21f8b4d
fixed records for pipelines_extended
midavadim Feb 15, 2024
9cc9317
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Feb 15, 2024
c2df44c
fixed expected records
midavadim Feb 15, 2024
088e90a
Merge remote-tracking branch 'origin/midavadim/3864-source-gitlab-fix…
midavadim Feb 15, 2024
03848a4
fixed expected records
midavadim Feb 15, 2024
ecf1667
Merge branch 'master' into midavadim/3864-source-gitlab-fix-merge_req…
midavadim Feb 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ acceptance_tests:
tests:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: 1.8.4
disable_for_version: 3.0.0
basic_read:
tests:
- config_path: "secrets/config.json"
Expand All @@ -29,6 +29,9 @@ acceptance_tests:
jobs:
- name: "user"
bypass_reason: "User object contains local_time which will be different each time test is run"
projects:
- name: "updated_at"
bypass_reason: "value can be changed"
- config_path: "secrets/config_with_ids.json"
timeout_seconds: 3600
empty_streams:
Expand All @@ -42,6 +45,9 @@ acceptance_tests:
jobs:
- name: "user"
bypass_reason: "User object contains local_time which will be different each time test is run"
projects:
- name: "updated_at"
bypass_reason: "value can be changed"
- config_path: "secrets/config_oauth.json"
timeout_seconds: 3600
expect_records:
Expand All @@ -50,6 +56,9 @@ acceptance_tests:
jobs:
- name: "user"
bypass_reason: "User object contains local_time which will be different each time test is run"
projects:
- name: "updated_at"
bypass_reason: "value can be changed"
incremental:
tests:
- config_path: "secrets/config_with_ids.json"
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion airbyte-integrations/connectors/source-gitlab/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 5e6175e5-68e1-4c17-bff9-56103bbb0d80
dockerImageTag: 2.1.1
dockerImageTag: 3.0.0
dockerRepository: airbyte/source-gitlab
documentationUrl: https://docs.airbyte.com/integrations/sources/gitlab
githubIssueLabel: source-gitlab
Expand All @@ -29,6 +29,14 @@ data:
releaseStage: generally_available
releases:
breakingChanges:
3.0.0:
message:
In this release, merge_request_commits stream schema has been fixed so that it returns commits for each merge_request.
Users will need to refresh the source schema and reset merge_request_commits stream after upgrading.
upgradeDeadline: "2024-02-13"
scopedImpact:
- scopeType: stream
impactedScopes: ["merge_request_commits"]
2.0.0:
message:
In this release, several streams were updated to date-time field format, as declared in the Gitlab API.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,10 @@ def migrate(cls, args: List[str], source: SourceGitlab) -> None:


class MigrateGroups(MigrateStringToArray):

migrate_from_key: str = "groups"
migrate_to_key: str = "groups_list"


class MigrateProjects(MigrateStringToArray):

migrate_from_key: str = "projects"
migrate_to_key: str = "projects_list"
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,12 @@
},
"group_id": {
"type": ["null", "integer"]
},
"human_readable_end_date": {
"type": ["null", "string"]
},
"human_readable_timestamp": {
"type": ["null", "string"]
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,17 @@
}
}
}
},
"allowed_to_push": {
"type": ["null", "array"],
"items": {
"type": ["null", "object"],
"properties": {
"access_level": {
"type": ["null", "integer"]
}
}
}
}
}
},
Expand Down Expand Up @@ -74,6 +85,9 @@
"subgroup_creation_level": {
"type": ["null", "string"]
},
"enabled_git_access_protocol": {
"type": ["null", "string"]
},
"emails_disabled": {
"type": ["null", "boolean"]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@
},
"id": {
"type": ["null", "integer"]
},
"locked": {
"type": ["null", "boolean"]
}
}
},
Expand All @@ -141,6 +144,12 @@
},
"username": {
"type": ["null", "string"]
},
"id": {
"type": ["null", "integer"]
},
"locked": {
"type": ["null", "boolean"]
}
}
},
Expand All @@ -164,6 +173,18 @@
},
"username": {
"type": ["null", "string"]
},
"human_readable_end_date": {
"type": ["null", "string"]
},
"human_readable_timestamp": {
"type": ["null", "string"]
},
"id": {
"type": ["null", "integer"]
},
"locked": {
"type": ["null", "boolean"]
}
}
},
Expand Down Expand Up @@ -251,6 +272,15 @@
},
"group_id": {
"type": ["null", "integer"]
},
"locked": {
"type": ["null", "boolean"]
},
"human_readable_end_date": {
"type": ["null", "string"]
},
"human_readable_timestamp": {
"type": ["null", "string"]
}
}
},
Expand Down
Loading
Loading