-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: override secrets scrubbing in very few cases #34555
Merged
postamar
merged 4 commits into
master
from
postamar/airbyte-ci-less-aggressive-secrets-scrubbing
Jan 26, 2024
Merged
airbyte-ci: override secrets scrubbing in very few cases #34555
postamar
merged 4 commits into
master
from
postamar/airbyte-ci-less-aggressive-secrets-scrubbing
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
alafanechere
approved these changes
Jan 26, 2024
airbyte-ci/connectors/pipelines/pipelines/dagger/actions/secrets.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/dagger/actions/secrets.py
Outdated
Show resolved
Hide resolved
…ts.py Co-authored-by: Augustin <augustin@airbyte.io>
…ts.py Co-authored-by: Augustin <augustin@airbyte.io>
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
…4555) Co-authored-by: Augustin <augustin@airbyte.io>
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…4555) Co-authored-by: Augustin <augustin@airbyte.io>
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…4555) Co-authored-by: Augustin <augustin@airbyte.io>
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…4555) Co-authored-by: Augustin <augustin@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the string
postgres
. It's marked as secret, probably because it's the default username for a test database somewhere. Secrets are masked in logs produced by airbyte-ci. Masking the substringpostgres
when testingsource-postgres
results in the test report being littered withsource-*****
strings in highly-visible places like URLs, which defeats the purpose because it's readily apparent thatpostgres
is that secret and therefore that our shared test instance's user name ispostgres
.This PR changes airbyte-ci to override masking in cases like these, and also for common words which I've identified were marked as secrets.