Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: override secrets scrubbing in very few cases #34555

Merged

Conversation

postamar
Copy link
Contributor

Consider the string postgres. It's marked as secret, probably because it's the default username for a test database somewhere. Secrets are masked in logs produced by airbyte-ci. Masking the substring postgres when testing source-postgres results in the test report being littered with source-***** strings in highly-visible places like URLs, which defeats the purpose because it's readily apparent that postgres is that secret and therefore that our shared test instance's user name is postgres.

This PR changes airbyte-ci to override masking in cases like these, and also for common words which I've identified were marked as secrets.

@postamar postamar requested a review from a team January 26, 2024 14:56
Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 3:43pm

postamar and others added 2 commits January 26, 2024 07:42
…ts.py

Co-authored-by: Augustin <augustin@airbyte.io>
…ts.py

Co-authored-by: Augustin <augustin@airbyte.io>
@postamar postamar enabled auto-merge (squash) January 26, 2024 15:43
@postamar postamar merged commit 9815a10 into master Jan 26, 2024
24 checks passed
@postamar postamar deleted the postamar/airbyte-ci-less-aggressive-secrets-scrubbing branch January 26, 2024 16:11
Copy link

sentry-io bot commented Jan 30, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ExecError: process "ci_credentials source-s3 write-to-storage" did not complete successfully: exit code: 1 dagger.client._core in execute View Issue
  • ‼️ ExecError: process "ci_credentials source-mssql write-to-storage" did not complete successfully: exit code: 1 dagger.client._core in execute View Issue
  • ‼️ QueryError: unexpected status from HEAD request to https://registry-1.docker.io/v2/library/python/manifests/3... dagger.client._core in execute View Issue
  • ‼️ QueryError: failed to compute cache key: failed to get layer download url for digest sha256:89b7dca1cbba7fdd1... dagger.client._core in execute View Issue

Did you find this useful? React with a 👍 or 👎

jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants