-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AirbyteLib: More robust error handling, installation improvements #34572
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
abbb256
new exception type: AirbyteConnectorNotRegisteredError
aaronsteers 3845f5c
make constructors more resilient
aaronsteers 9fccace
print stderr in exception text, cleanup failed install, remove editab…
aaronsteers a217a6e
move auto-install out of venv constructor, for easier debugging
aaronsteers 6aa85d6
add test to assert that install failure includes pip log text
aaronsteers dddbc78
update docs
aaronsteers b1d966b
auto-format
aaronsteers f61152a
update docs
aaronsteers d665088
refactor version handling, control for side effects
aaronsteers 809918b
fix exception handling in _get_installed_version()
aaronsteers 4a41ffb
fix tests
aaronsteers bab5e06
improve thread safety
aaronsteers 10ce077
handle quoted spaces in pip_url
aaronsteers 063bba3
fix import sorts
aaronsteers ab75be4
standalone validate_config() method
aaronsteers 8880b0b
add Source.yaml_spec property
aaronsteers 3773149
make _yaml_spec a protected member
aaronsteers 90918c8
fix too-limited json package_data glob
aaronsteers 9197728
fix missing copyright str
aaronsteers f73f288
docstring
aaronsteers dd9ac99
update docs
aaronsteers a2bed01
revert source-github change
aaronsteers 2e49154
updated comment
aaronsteers f975282
remove redundant strings
aaronsteers ace7208
Merge remote-tracking branch 'origin/master' into aj/airbyte-lib/inst…
aaronsteers 8775c1b
update docs (removes empty cloud page)
aaronsteers f24226d
remove unused lock
aaronsteers 7370d83
rename AirbyteConnectoNotFoundError to AirbyteConnectorExecutableNotF…
aaronsteers cfafccc
Merge branch 'master' into aj/airbyte-lib/install-failure-handling
aaronsteers 8446838
allow prereleases in version check
aaronsteers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the advantage of deferring the check? I thought of it being quite nice as it will tell you as early as possible if your config won't work, instead of waiting for actually invoking.
What's the workflow you had in mind here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in DM.