refactor debezium harness in CDK, push connector-specific logic down to connectors #34573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Coverage report for source-postgres
|
octavia-squidington-iii
added
area/documentation
postamar
force-pushed
the
postamar/unentangle-debezium
branch
from
5d1c30a
to
ab660f4
Compare
postamar
force-pushed
the
postamar/unentangle-debezium
branch
from
ab660f4
to
7fcef6a
Compare
postamar
changed the title
stephane-airbyte
approved these changes
Jan 27, 2024
|
/publish-java-cdk
|
This reverts commit 932032c.
|
/approve-and-merge reason="source-mysql has flaky tests, not related to changes here" |
|
This is really good |
octavia-approvington
approved these changes
Jan 27, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of restructuring the CDK I stumbled on the tangled knot of dependencies that was our debezium harness. This PR untangles it. Debezium-with-mongo code is moved out of the CDK and into source-mongodb-v2, same with postgres and mysql. @stephane-airbyte had already taken care of mssql.
This is best reviewed commit-by-commit. First we have the version number change boilerplate. The next commits, up to but not including the last, work towards removing the
DebeziumConnectorTypeenum from the debezium harness. This makes it possible to inject mongo-specific-dependencies intoAirbyteDebeziumHandlerinstead of dispatching on that enum value deeper down. Once that is done, the final commit straightforwardly moves the connector-specific source files from the CDK to the respective connectors.