Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Azure Table Storage: CDK Update #34576

Merged
merged 6 commits into from Jan 31, 2024
Merged

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Jan 26, 2024

What

This PR is part of the larger project to republish older Community connectors with updated CDK versions in preparation for the deprecation of legacy state. Source Azure Table was unable to be republished due to a couple small bugs and an empty test account. It should now be unblocked for publishing and future development, and airbytehq/airbyte-internal-issues#2554 is resolved.

How

  • Couple small fixes/updates to address CAT failures
  • Seeded a small data sample in our test account
  • Updated test_config file
  • Increased unit test coverage and moved existing fixtures to conftest.py

Suggested Reading Order

  1. source_azure_table/source.py
  2. source_azure_table/streams.py
  3. unit_tests/*.py

User Impact

Bugfix/unblocking PR, no changes to implementation

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 2:46pm

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@ChristoGrab ChristoGrab merged commit 78a6047 into master Jan 31, 2024
41 checks passed
@ChristoGrab ChristoGrab deleted the christo/azure-table-cdk branch January 31, 2024 15:47
jbfbell pushed a commit that referenced this pull request Feb 1, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/azure-table
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants