Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle exceptions in waitForTemporalServerandLog #3460

Merged
merged 2 commits into from
May 18, 2021
Merged

Handle exceptions in waitForTemporalServerandLog #3460

merged 2 commits into from
May 18, 2021

Conversation

avaidyanatha
Copy link
Contributor

Main Changes

  • Adds a try/catch to waitForTemporalServerAndLog so that the scheduler doesn't fail if Temporal throws an exception our way.
  • Adds a test for this case to check behavior on exceptions

Notes

Closes #2893

@avaidyanatha avaidyanatha added the area/platform issues related to the platform label May 17, 2021
@avaidyanatha avaidyanatha requested review from marcosmarxm and removed request for ChristopheDuong and cgardens May 17, 2021 23:12
@avaidyanatha avaidyanatha merged commit d4bcb18 into master May 18, 2021
@avaidyanatha avaidyanatha deleted the abhi/exceptional-java branch May 18, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

@sherifnada sherifnada sherifnada approved these changes

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

Assignees
No one assigned
Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scheduler can fail until restart if temporal isn't ready on startup
3 participants
@avaidyanatha @jrhizor @sherifnada