Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝Destination Astra DB Connector Name Update, Icon Update, Spec formatting and tooltips #34600

Merged
merged 26 commits into from
Jan 30, 2024

Conversation

flash1293
Copy link
Contributor

New setup from #34566

With following changes:

  • Release date in metadata.yml doesn't need to be adjusted, this is the initial release date
  • Changelog goes by date descending
  • Made icon background transparent
  • Regenerated spec to match the generated one
  • Reformat

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 11:01am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/astra labels Jan 29, 2024
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@flash1293 flash1293 merged commit f10763a into master Jan 30, 2024
27 of 29 checks passed
@flash1293 flash1293 deleted the flash1293/astra-docs-change branch January 30, 2024 09:35
clnoll pushed a commit that referenced this pull request Jan 30, 2024
…ting and tooltips (#34600)

Co-authored-by: Obioma Anomnachi <onanomnachi@gmail.com>
jbfbell pushed a commit that referenced this pull request Feb 1, 2024
…ting and tooltips (#34600)

Co-authored-by: Obioma Anomnachi <onanomnachi@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
…ting and tooltips (airbytehq#34600)

Co-authored-by: Obioma Anomnachi <onanomnachi@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…ting and tooltips (airbytehq#34600)

Co-authored-by: Obioma Anomnachi <onanomnachi@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…ting and tooltips (airbytehq#34600)

Co-authored-by: Obioma Anomnachi <onanomnachi@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…ting and tooltips (airbytehq#34600)

Co-authored-by: Obioma Anomnachi <onanomnachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/astra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants