Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source: Klaviyo #3463

Merged
merged 18 commits into from
May 19, 2021
Merged

🎉 New Source: Klaviyo #3463

merged 18 commits into from
May 19, 2021

Conversation

keu
Copy link
Contributor

@keu keu commented May 18, 2021

What

closes #1352

How

Describe the solution

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. schemas.py
  2. streams.py
  3. source.py

@keu keu changed the title New Source: Klaviyo 🎉 New Source: Klaviyo May 18, 2021
yevhenii-ldv
yevhenii-ldv reviewed May 18, 2021
View reviewed changes
airbyte-integrations/connectors/source-klaviyo/integration_tests/sample_state.json
@@ -0,0 +1,5 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use this file if we always have abnormal_state.json ? It looks like a small duplicate, WDYT?

@keu
Copy link
Contributor Author

keu commented May 18, 2021 •
edited by github-actions bot

/test connector=source-klaviyo

🕑 source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/853567408
❌ source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/853567408

@keu
Copy link
Contributor Author

keu commented May 18, 2021 •
edited by github-actions bot

/test connector=source-klaviyo

🕑 source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/853641835
✅ source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/853641835

sherifnada
sherifnada suggested changes May 18, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly some questions but we should be gtg after

airbyte-integrations/connectors/source-klaviyo/acceptance-test-config.yml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/acceptance-test-config.yml Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/acceptance-test-docker.sh Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/integration_tests/fixtures.py Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/schemas.py Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/streams.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/streams.py Outdated Show resolved Hide resolved
@keu keu requested review from sherifnada and removed request for ChristopheDuong May 18, 2021 17:58
@keu
Copy link
Contributor Author

keu commented May 18, 2021 •
edited by github-actions bot

/test connector=source-klaviyo

🕑 source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/854407989
❌ source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/854407989

@keu
Copy link
Contributor Author

keu commented May 19, 2021 •
edited by github-actions bot

/publish connector=connectors/source-klaviyo

🕑 connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/858461171
✅ connectors/source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/858461171

@keu keu merged commit d2eb5c0 into master May 19, 2021
@keu keu deleted the keu/source-klaviyo branch May 19, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@yevhenii-ldv yevhenii-ldv yevhenii-ldv approved these changes

@htrueman htrueman Awaiting requested review from htrueman

@Zirochkaa Zirochkaa Awaiting requested review from Zirochkaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Source: Klaviyo
4 participants
@keu @sherifnada @yevhenii-ldv @eugene-kulak