Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Hubspot: Fix pagination for companies_properties_history stream #34635

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Jan 29, 2024

What

Fixed https://github.com/airbytehq/oncall/issues/4101
Fixed #34304

How

Changed pagination key from hasMore to has-more. Docs - https://legacydocs.hubspot.com/docs/methods/companies/get-all-companies

🚨 User Impact 🚨

No

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 7:49pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot labels Jan 29, 2024
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 29, 2024 21:26
@lazebnyi lazebnyi requested review from johnwasserman and removed request for a team January 29, 2024 21:26
@lazebnyi lazebnyi changed the title 🐛 Source Hubspot: Fix pagination 🐛 Source Hubspot: Fix pagination for 'companies_properties_history' stream Jan 30, 2024
@lazebnyi lazebnyi changed the title 🐛 Source Hubspot: Fix pagination for 'companies_properties_history' stream 🐛 Source Hubspot: Fix pagination for ʼcompanies_properties_historyʼ stream Jan 30, 2024
@lazebnyi lazebnyi changed the title 🐛 Source Hubspot: Fix pagination for ʼcompanies_properties_historyʼ stream 🐛 Source Hubspot: Fix pagination for companies_properties_history stream Jan 30, 2024
@lazebnyi lazebnyi changed the title 🐛 Source Hubspot: Fix pagination for companies_properties_history stream 🐛 Source Hubspot: Fix pagination for companies_properties_history stream Jan 30, 2024
@DDynamic
Copy link
Contributor

DDynamic commented Feb 1, 2024

Duplicate of #34305

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Feb 1, 2024

@DDynamic Thanks for the mentions. I haven't seen your PR.

@lazebnyi lazebnyi merged commit 8dbbf7a into master Feb 1, 2024
24 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/4101-source-hubspot-fix-pagination branch February 1, 2024 21:08
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[source-hubspot] Incomplete companies property history stream
4 participants