New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Source Amazon Seller Partner: fix date format in state message for streams with custom dates formatting #34654
🐛Source Amazon Seller Partner: fix date format in state message for streams with custom dates formatting #34654
Conversation
…reams with custom dates formatting
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
def _transform_report_record_cursor_value(self, date_string: str) -> str: | ||
""" | ||
Parse report date field based using transformer defined in the stream class | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the example of the input/output to the docstring.
…treams with custom dates formatting (#34654)
…treams with custom dates formatting (airbytehq#34654)
…treams with custom dates formatting (airbytehq#34654)
…treams with custom dates formatting (airbytehq#34654)
…treams with custom dates formatting (airbytehq#34654)
…treams with custom dates formatting (#34654)
What
Align dates format in state messages and records for streams with custom dates formatting
How
Apply custom transformation in
get_updated_state
Recommended reading order
streams.py
🚨 User Impact 🚨
This is NOT a breaking change since these streams don't have active customers on cloud
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.