Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin file-based sources to airbyte-cdk version 0.59.2 #34661

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Pin file-based sources to airbyte-cdk version 0.59.2 #34661

merged 3 commits into from
Jan 30, 2024

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jan 30, 2024

Pinned until they can be made compatible with #34411, which runs full refreshes concurrently.

@clnoll clnoll requested a review from flash1293 January 30, 2024 15:49
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 4:30pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 30, 2024
@clnoll clnoll requested a review from maxi297 January 30, 2024 15:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited by clnoll
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 30, 2024
@clnoll
Copy link
Contributor Author

clnoll commented Jan 30, 2024 •
edited
Loading

I'm not including S3 because it's in the process of being upgraded.

flash1293
flash1293 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the version in metadata.yaml

@clnoll
Copy link
Contributor Author

clnoll commented Jan 30, 2024

Thank you @flash1293! I felt like I was missing something.

@clnoll clnoll requested a review from flash1293 January 30, 2024 16:31
maxi297
maxi297 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there CDK features we fear might be blocked by this? When do we expect a fix?

flash1293
flash1293 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clnoll
Copy link
Contributor Author

clnoll commented Jan 30, 2024

@maxi297 the fix should be straightforward and I'll either reach out to GL or do it quickly this afternoon.

maxi297
maxi297 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we have a plan for the fix, LGTM!

@clnoll clnoll merged commit aec1082 into master Jan 30, 2024
29 checks passed
@clnoll clnoll deleted the pin-file-based-connectors branch January 30, 2024 18:30
jbfbell pushed a commit that referenced this pull request Feb 1, 2024
@clnoll @jbfbell
Pin file-based sources to airbyte-cdk version 0.59.2 (#34661)
82b7e5d
@jbfbell jbfbell mentioned this pull request Feb 21, 2024
Closed
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@clnoll @jatinyadav-cc
Pin file-based sources to airbyte-cdk version 0.59.2 (airbytehq#34661)
d649ecb
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@clnoll @jatinyadav-cc
Pin file-based sources to airbyte-cdk version 0.59.2 (airbytehq#34661)
0c3d905
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@clnoll @jatinyadav-cc
Pin file-based sources to airbyte-cdk version 0.59.2 (airbytehq#34661)
eea3515
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@clnoll @jatinyadav-cc
Pin file-based sources to airbyte-cdk version 0.59.2 (airbytehq#34661)
c7da854
@jbfbell jbfbell mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@maxi297 maxi297 maxi297 approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/azure-blob-storage connectors/source/gcs connectors/source/google-drive connectors/source/microsoft-onedrive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clnoll @flash1293 @maxi297 @octavia-squidington-iii